Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display correct missing route in 404 page #2083

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

batzlerg
Copy link
Contributor

What's the purpose of this pull request?

display the correct missing URL when hitting a 404 page
#2064

How it works?

use asPath which Next provides as the alias for that particular 404 response

How to test it?

  1. visit path which doesn't exist
  2. see that the URL is displayed in the body of the page

Starters Deploy Preview

References

@batzlerg batzlerg requested a review from a team as a code owner October 27, 2023 19:25
@batzlerg batzlerg requested review from emersonlaurentino and renatamottam and removed request for a team October 27, 2023 19:25
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 7:28pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77cd49d:

Sandbox Source
Store UI Typescript Configuration

@batzlerg batzlerg changed the title use asPath instead of from to display correct missing route display correct missing route in 404 page Oct 27, 2023
@emersonlaurentino emersonlaurentino merged commit 1efa0ef into vtex:main Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants