Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Custom Cypress test doc improvements #2092

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

lucasfp13
Copy link
Contributor

What's the purpose of this pull request?

This PR intends to improve the Custom Cypress test docs.

@lucasfp13 lucasfp13 self-assigned this Nov 2, 2023
@lucasfp13 lucasfp13 requested a review from a team as a code owner November 2, 2023 13:34
@lucasfp13 lucasfp13 requested review from eduardoformiga and renatamottam and removed request for a team November 2, 2023 13:34
Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 0:23am

Copy link

codesandbox-ci bot commented Nov 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit caf1b8e:

Sandbox Source
Store UI Typescript Configuration

@lucasfp13
Copy link
Contributor Author

lucasfp13 commented Nov 20, 2023

When we use "for some projects", why is it not recommended for some projects? 👀

@mariana-caetano we do not recommend this for any FastStore project because they will be skipping the OOTB integration tests

@lucasfp13 lucasfp13 requested review from hellofanny and mariana-caetano and removed request for eduardoformiga and renatamottam November 20, 2023 13:26
Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@mariana-caetano mariana-caetano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions about the headings, but I've already pre-approved 🚀

Co-authored-by: Mariana Caetano Pereira <[email protected]>
@lucasfp13 lucasfp13 merged commit 9af9c4c into main Nov 21, 2023
@lucasfp13 lucasfp13 deleted the docs/custom-cypress-test-fix branch November 21, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants