docs: Adds doc about experimental exports (hooks + components) #2192
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hellofanny
requested review from
eduardoformiga,
lucasfp13,
mariana-caetano and
a team
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6aa1044:
|
There was a problem hiding this comment.
LGTM! ✨
I wonder if would be good to mention this doc in the "Building and Customizing sections" doc.
good idea, or we can link it here in the overriding native section 🤔 I'll check with @mariana-caetano :) |
|
|
||
| - Image_unstable | ||
|
|
||
| <Callout type="info" emoji="ℹ️"> |
There was a problem hiding this comment.
@eduardoformiga and @mariana-caetano I've added this callout and example of using Image component, can you review it again pls
There was a problem hiding this comment.
Good Job, @hellofanny.
Since this component comes from the core package instead of components. I think we should give more visibility of how to use it and how it's defined somehow.
https://github.com/vtex/faststore/blob/105a8b2f69ffd8438532d7c9eb959ed26a567675/packages/core/src/components/ui/Image/Image.tsx
Edit: We have this doc https://faststore-git-faststore-images-faststore.vercel.app/how-to-guides/performance/setting-up-faststore-images
It would be good to extract just the relevant information from this doc. (we can do it in another task)
There was a problem hiding this comment.
Thanks forms!! Sounds good, for now I've just linked the component to the code 🙈 . But I've added another task just for it.
There was a problem hiding this comment.
Great job, @hellofanny! 🚀
Another suggestion - I believe we've discussed and Formiga also said - is to move this doc to the Building and customizing sections track. This doc will work as a reference guide like the List of Native Sections and Overridable Components.
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Thanks Mari! I've moved it to the building and customize section :) |
What's the purpose of this pull request?
Adds doc about hooks and components experimental exports. This is a handy tool when customizing components, but it was not explicit in our documentation.
This possibility was introduced previously in #2033
Preview doc: https://faststore-site-git-docs-experimental-exports-hooks-faststore.vercel.app/docs/building-sections/experimental-exports
References
#2033