feat: Get rid of node_modules symlink
#2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d316b75:
|
This reverts commit 4d5a310.
gvc
commented
Jan 11, 2024
gvc
commented
Jan 11, 2024
lucasfp13
requested review from
eduardoformiga and
lucasfp13
and removed request for
a team
There was a problem hiding this comment.
Good Job! ✨ (I'd recommend adding any description to this PR, even a simpler one)
I left some comments and curiosities along the review haha
Do you think in the future we can move some of the CLI job to the cicd workflow? to be less cli dependent, or would be cumbersome somehow?
| @@ -45,7 +32,7 @@ async function copyResource(from: string, to: string) { | |||
| removeSync(to) | |||
| } | |||
|
|
|||
| await copySync(from, to) | |||
| copySync(from, to) | |||
Co-authored-by: Eduardo Formiga <[email protected]>
lucasfp13
reviewed
Jan 11, 2024
eduardoformiga
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes prevent the user's
node_modulesdirectory to be sent to the build pipeline and remove the symbolic link.Next.js standalone build only needs that to create the production-ready
.next/standaloneoutput.