Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Updates GA events with category field #2414

Open
wants to merge 155 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
155 commits
Select commit Hold shift + click to select a range
8ee5eff
test: return values in resolver
lucvysk Aug 14, 2024
3f3cc71
test: add in the gph
lucvysk Aug 14, 2024
f0ede41
test: returning category id
lucvysk Aug 14, 2024
b855d67
feat: return categories
lucvysk Aug 14, 2024
9ec1473
feat: event "useViewItemListEvent" returning categories
lucvysk Aug 14, 2024
ab2a4f2
chore: update GA event "view_item"and "select_item
lucvysk Aug 15, 2024
b897ed2
feat: add categories to GA event "add_to_cart
lucvysk Aug 15, 2024
23ba6ce
feat: add categories to GA events "remove_from_cart" and "view_cart
lucvysk Aug 15, 2024
6441345
chore: remove consoles
lucvysk Aug 15, 2024
bf42f94
fix: parse search prop for GA event
lucvysk Aug 15, 2024
47d4f1a
fix: list issues
lucvysk Aug 15, 2024
ff12ccf
Chore(deps): Bump braces from 3.0.2 to 3.0.3 (#2345)
dependabot[bot] Aug 19, 2024
f8acb46
Chore(deps): Bump axios from 1.6.8 to 1.7.4 (#2418)
dependabot[bot] Aug 22, 2024
c874481
[no ci] Release: 3.0.94
Aug 22, 2024
44234ba
metatag generated at (#2417)
emersonlaurentino Aug 22, 2024
a548fc5
release: FastStore core v3.0.94 (#2421)
hellofanny Aug 23, 2024
75f7614
[no ci] Release: 3.0.95
Aug 23, 2024
af0de61
Feat: Adds Card Component (#2398)
ataideverton Sep 2, 2024
dbcdb34
[no ci] Release: 3.0.96
Sep 2, 2024
e405d05
Fix: duplicated queries due to hasOnlyDefaultSalesChannel (#2429)
lariciamota Sep 3, 2024
22f2107
Fix: Rollback fuzzy params in PLP (#2427)
eduardoformiga Sep 3, 2024
df0e2d3
[no ci] Release: 3.0.97
Sep 3, 2024
2857b66
Fix: Add 'show-invisible-items' parameter to IntelligentSearch API (#…
emersonlaurentino Sep 4, 2024
8493dc0
[no ci] Release: 3.0.98
Sep 4, 2024
73d540e
fix: validateCart mutation merging orderForm items with assemply opti…
JoelsonFerreiraM3 Sep 5, 2024
c37b1d1
[no ci] Release: 3.0.99
Sep 5, 2024
0917e4e
Feat: Make simulationBehavior search param configurable (#2439)
lariciamota Sep 10, 2024
3670e78
[no ci] Release: 3.0.100
Sep 10, 2024
f25908c
fix: adds optional icon to icon prop (#2443)
eduardoformiga Sep 10, 2024
160a160
[no ci] Release: 3.0.101
Sep 10, 2024
3cfc198
Fix: Custom theme import priority (#2442)
JoelsonFerreiraM3 Sep 11, 2024
ea14927
[no ci] Release: 3.0.102
Sep 11, 2024
cd93d30
Feat: Adds jest-axe and Card component test (#2440)
hellofanny Sep 12, 2024
666e630
[no ci] Release: 3.0.103
Sep 12, 2024
560d92f
chore: rename init command to create (#2453)
gvc Sep 13, 2024
db56d15
[no ci] Release: 3.0.104
Sep 13, 2024
3311518
chore: Moves lighthouse pkg from devDependencies to dependencies (#2456)
hellofanny Sep 13, 2024
6d4dd3b
[no ci] Release: 3.0.105
Sep 13, 2024
5068098
feat: trigger critical events for analytics (#2394)
JoelsonFerreiraM3 Sep 16, 2024
238c6a2
[no ci] Release: 3.0.106
Sep 16, 2024
f238f14
feat: Adds B2B Customer ID (#2405)
ataideverton Sep 16, 2024
7642176
[no ci] Release: 3.0.107
Sep 16, 2024
a057cb8
Revert "feat: Adds B2B Customer ID" (#2459)
hellofanny Sep 16, 2024
300edad
[no ci] Release: 3.0.108
Sep 16, 2024
59ca310
Chore(deps): Bump dset from 3.1.2 to 3.1.4 (#2449)
dependabot[bot] Sep 23, 2024
1bc6245
docs: update version on readme (#2445)
emersonlaurentino Sep 23, 2024
cfa2b76
[no ci] Release: 3.0.109
Sep 23, 2024
33aa4a3
Chore(deps): Bump @grpc/grpc-js from 1.8.14 to 1.11.2 (#2450)
dependabot[bot] Sep 23, 2024
8697c6c
feat: add sendPageViewEvent to useEffect dependencies (#2467)
pedromtec Sep 24, 2024
c2922d7
[no ci] Release: 3.0.110
Sep 24, 2024
8a94f6b
Feat: adds new `deviceSizes` and adjust `Hero` Image (#2470)
eduardoformiga Sep 24, 2024
8a64be2
[no ci] Release: 3.0.111
Sep 24, 2024
7a787be
feat: removes lazy without suspense from global sections (#2468)
eduardoformiga Sep 24, 2024
e2326e5
[no ci] Release: 3.0.112
Sep 24, 2024
a09f274
feat: removes nextjs-progressbar and chalk (#2469)
eduardoformiga Sep 24, 2024
47915ea
[no ci] Release: 3.0.113
Sep 24, 2024
2a8eade
Feat: `Promise.all` homepage and global Promises (#2471)
eduardoformiga Sep 24, 2024
7948467
[no ci] Release: 3.0.114
Sep 24, 2024
2d6d89e
Fix: Integration and enable back accessibility tests (#2458)
hellofanny Sep 26, 2024
1cc987d
[no ci] Release: 3.0.115
Sep 26, 2024
2416791
Chore: Updates FastStore Contributing Guide (#2476)
hellofanny Sep 27, 2024
9abc0dd
chore: removes mark from components/sections (#2478)
eduardoformiga Sep 27, 2024
d1224a9
Feat: adds preconnect and dns-prefetch (#2477)
eduardoformiga Sep 27, 2024
944909c
[no ci] Release: 3.0.116
Sep 27, 2024
cc3cc88
Add showSponsored as api configuration on faststore.config.js to Inte…
fltiago Oct 1, 2024
7f082b4
[no ci] Release: 3.0.117
Oct 1, 2024
1730e2b
Refactor import paths to use discovery.config (#2486)
emersonlaurentino Oct 2, 2024
9fc28dc
[no ci] Release: 3.0.118
Oct 2, 2024
8ec05cb
Refactor import paths to use discovery.config (#2488)
emersonlaurentino Oct 2, 2024
ca6a0f3
[no ci] Release: 3.0.119
Oct 2, 2024
2d78a44
feat: Adds B2B Customer ID (#2462)
ataideverton Oct 3, 2024
26ffe66
[no ci] Release: 3.0.120
Oct 3, 2024
65329b3
Chore: Add checkDependencies function to generate script (#2447)
emersonlaurentino Oct 3, 2024
bf2236a
[no ci] Release: 3.0.121
Oct 3, 2024
1bc04d6
fix(api): slugify breaking category with pipe in its name (#2490)
lariciamota Oct 3, 2024
e1b59db
[no ci] Release: 3.0.122
Oct 3, 2024
689932d
fix: import paths to use discovery.config (#2489)
emersonlaurentino Oct 4, 2024
0aa8ed0
[no ci] Release: 3.0.123
Oct 4, 2024
30129a8
Chore: Updates Envelop from v2 to v3 (#2473)
lariciamota Oct 4, 2024
0d1c7d8
[no ci] Release: 3.0.124
Oct 4, 2024
7b74bcc
Chore: Removes `BannerNewsletter` section from home (#2481)
hellofanny Oct 7, 2024
88513e1
[no ci] Release: 3.0.125
Oct 7, 2024
f904765
Fix: codegen dependencies (#2496)
pedromtec Oct 8, 2024
52d1483
[no ci] Release: 3.0.126
Oct 8, 2024
8838ee8
Feat: import `sendAnalyticsEvent` on demand (#2472)
eduardoformiga Oct 8, 2024
7d80430
[no ci] Release: 3.0.127
Oct 8, 2024
d88a361
chore: adjust CLI to meet FSP Spec (#2491)
gvc Oct 8, 2024
37e2acf
[no ci] Release: 3.0.128
Oct 8, 2024
999f632
Chore: Updates Envelop from v3 to v4 (#2479)
lariciamota Oct 9, 2024
8de84b1
[no ci] Release: 3.0.129
Oct 9, 2024
67b50bd
chore: Migrate envelop core to v5 (#2480)
lariciamota Oct 10, 2024
397a6ee
[no ci] Release: 3.0.130
Oct 10, 2024
3885116
Feat: Adds intersection (ViewportObserver) component (#2498)
hellofanny Oct 11, 2024
3e4e1b9
feat: enable preact experimental feature (#2497)
pedromtec Oct 11, 2024
79ad36c
[no ci] Release: 3.0.131
Oct 11, 2024
c94a768
feat: Add `useScreenResize` hook (SFS-1509) (#2487)
lucasfp13 Oct 14, 2024
a99b6bc
[no ci] Release: 3.0.132
Oct 14, 2024
04cb411
Enable monorepo build on Vercel (#2500)
gvc Oct 17, 2024
0666c16
[no ci] Release: 3.0.133
Oct 17, 2024
3b67502
Upgrade turbo (#2512)
emersonlaurentino Oct 17, 2024
0c86977
[no ci] Release: 3.0.134
Oct 17, 2024
ce2b49e
chore: remove changelog (#2513)
emersonlaurentino Oct 18, 2024
6112836
[no ci] Release: 3.0.135
Oct 18, 2024
1ca4ffc
Decrease FastStore CLI verbosity (#2516)
gvc Oct 24, 2024
b2aecbd
[no ci] Release: 3.0.136
Oct 24, 2024
992cab3
chore: Applies next/dynamic for RegionModal (#2523)
hellofanny Oct 24, 2024
180d1b1
[no ci] Release: 3.0.137
Oct 24, 2024
04d045d
Feat: adds LazyLoadingSection component - perf (#2521)
hellofanny Oct 28, 2024
91d2669
[no ci] Release: 3.0.138
Oct 28, 2024
6bd8093
fix: don't move .next directory if it is in the correct place (#2532)
gvc Oct 30, 2024
7be359d
[no ci] Release: 3.0.139
Oct 30, 2024
2308e86
fix: has child items logic on validate cart (bug) (#2524)
EmanuelRamos115 Oct 31, 2024
5d08521
[no ci] Release: 3.0.140
Oct 31, 2024
c92d785
Feat: Improve Dropdown Component (#2492)
ArthurTriis1 Nov 4, 2024
f972d71
[no ci] Release: 3.0.141
Nov 4, 2024
c201187
fix: uncomment middleware (#2535)
ArthurTriis1 Nov 4, 2024
16bd21d
[no ci] Release: 3.0.142
Nov 4, 2024
ea0f46b
Chore: Fix CLS issues and Navbar dynamic imports (#2526)
hellofanny Nov 4, 2024
6a949f2
[no ci] Release: 3.0.143
Nov 4, 2024
1777bd5
fix: NaN when string is inputed on quantity input (#2534)
EmanuelRamos115 Nov 5, 2024
90c18b6
[no ci] Release: 3.0.144
Nov 5, 2024
f4b78dc
Chore: Applies next/dynamic for Toast (#2538)
hellofanny Nov 6, 2024
8932019
[no ci] Release: 3.0.145
Nov 6, 2024
0930921
fix: Revert Navbar isMobile changes (#2541)
hellofanny Nov 6, 2024
5cbeb9b
[no ci] Release: 3.0.146
Nov 6, 2024
bc17e46
Feat: Applies next/dynamic for SearchInput & adjustments (#2550)
hellofanny Nov 11, 2024
5d3b33b
[no ci] Release: 3.0.147
Nov 11, 2024
6bbe1b1
Sfs 1755 generate middleware in build time (#2540)
pedromtec Nov 12, 2024
95acfb9
[no ci] Release: 3.0.148
Nov 12, 2024
80b2f71
fix: Consider `shouldSplitItem` value from `ValidateCart` mutation re…
lucasfp13 Nov 13, 2024
0f32844
[no ci] Release: 3.0.149
Nov 13, 2024
18a03f5
feat: next/dynamic in `BannerText` internal components SFS-1518 (#2552)
eduardoformiga Nov 19, 2024
286424c
feat: next/dynamic in `CartSidebar` internal components SFS-1517 (#2553)
eduardoformiga Nov 19, 2024
9a6903b
feat: split the global sections in own file (#2554)
eduardoformiga Nov 19, 2024
5d33a02
[no ci] Release: 3.0.150
Nov 19, 2024
cb83534
feat: split the homepage sections in own file (#2555)
eduardoformiga Nov 19, 2024
2285089
[no ci] Release: 3.0.151
Nov 19, 2024
24af4dc
chore: update turbo package to version 2.3.1 (#2573)
emersonlaurentino Nov 21, 2024
a5bf0c6
fix: fuzzy and operator usage when handling IS requests (#2568)
pedromtec Nov 21, 2024
98f7628
[no ci] Release: 3.0.152
Nov 21, 2024
074cefe
fix: Support `releaseId` query string param for Headless CMS previews…
lucasfp13 Nov 25, 2024
6f2e5b5
[no ci] Release: 3.0.153
Nov 25, 2024
6c38893
test: return values in resolver
lucvysk Aug 14, 2024
62527a0
test: add in the gph
lucvysk Aug 14, 2024
9751cb4
test: returning category id
lucvysk Aug 14, 2024
b236ec5
feat: return categories
lucvysk Aug 14, 2024
374a259
feat: event "useViewItemListEvent" returning categories
lucvysk Aug 14, 2024
d4b370e
chore: update GA event "view_item"and "select_item
lucvysk Aug 15, 2024
36a36bb
feat: add categories to GA event "add_to_cart
lucvysk Aug 15, 2024
93e08d9
feat: add categories to GA events "remove_from_cart" and "view_cart
lucvysk Aug 15, 2024
9389d89
chore: remove consoles
lucvysk Aug 15, 2024
0412efd
fix: parse search prop for GA event
lucvysk Aug 15, 2024
21c1f4f
fix: list issues
lucvysk Aug 15, 2024
bb0a816
Merge branch 'feat/ga-events-2' of https://github.com/vtex/faststore …
lucvysk Nov 26, 2024
84c3c9e
fix: change var to camel case
lucvysk Nov 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@

## How it works?

<!--- Tell us the role of the new feature, or component, in its context. --->
<!--- Tell us the role of the new feature, or component, in its context. Provide details about what you have implemented and screenshots if applicable. --->

## How to test it?

<!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? --->

### Starters Deploy Preview

<!--- Add a link to a deploy preview from `gatsby.store` AND `nextjs.store` with this branch being used. --->
<!--- Add a link to a deploy preview from `starter.store` with this branch being used. --->

<!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. --->

Expand All @@ -21,3 +21,20 @@
<!--- Spread the knowledge: is there any content you used to create this PR that is worth sharing? --->

<!--- Extra tip: adding references to related issues or mentioning people important to this PR may be good for the documentation and reviewing process --->

## Checklist

<em>You may erase this after checking them all :wink:</em>

**PR Title and Commit Messages**

- [ ] PR title and commit messages follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification
- Available prefixes: `feat`, `fix`, `chore`, `docs`, `style`, `refactor` and `test`

**PR Description**

- [ ] Added a label according to the PR goal - `breaking change`, `bug`, `contributing`, `performance`, `documentation`..

**Dependencies**

- [ ] Committed the `yarn.lock` file when there were changes to the packages
3,325 changes: 0 additions & 3,325 deletions CHANGELOG.md

This file was deleted.

96 changes: 75 additions & 21 deletions CONTRIBUTING.MD
Original file line number Diff line number Diff line change
@@ -1,56 +1,110 @@
# How to contribute
# How to contribute 🌟

1. Fork this repository.
Thank you for your interest in contributing! We welcome all kinds of contributions, whether they are bug fixes, new features, documentation improvements, or any other suggestions. This guide will walk you through the process of contributing to FastStore framework.

2. Clone your forked `faststore` repository.
## 1. Requirements

3. Create a new branch for the changes you are working on.
Before you begin, make sure you have the following installed on your local machine to run the project:

## Developing Locally
- [Git](https://git-scm.com)
- [Node.js](https://nodejs.org/en)
- [Yarn](https://yarnpkg.com/)
- [Turbo](https://turbo.build/repo/docs/getting-started/installation#installing-turbo)
- Your Preferred Code Editor (VSCode, Sublime, etc.)

### Developing Packages
## 2. Getting Started

1. Run `yarn` at the root of the repo.
### Forking the Repository

2. Run `yarn build` at the root of the repo.
**If you don’t have write access to this repository**, you'll need to fork it (else, skip this step):

Fork the repository (click the <kbd>Fork</kbd> button at the top right of
[this page](https://github.com/vtex/faststore)).This will create a copy of the repository in your GitHub account.

### Cloning the Repository

1. Open a terminal and clone the `faststore` repository.
2. Navigate into the project folder.

### Setting Up the Environment

1. Run `yarn` at the root of the repository.

2. Run `yarn build` at the root of the repository.

3. Run `yarn turbo run dev --filter={packageName}` to run a package individually.

> For example, if you want to run the `@faststore/core` package, at the root of the repo run:
> For example, if you want to run the `@faststore/core` package, at the root of the repository run:
>
> `yarn turbo run dev --filter=@faststore/core`

### Developing packages while also testing on a store
**Note**: If you encounter issues during the setup process, please check if your current version of Yarn, Turbo, and Node.js are matching the versions specified in the package.json file.

## 3. Working on an Issue

### Creating a New Branch

Before starting any work, create a new branch for your changes:

```
git checkout -b feat/your-branch-name
```

Choose a branch name that reflects the work being done, such as `fix/query-typo` or `feat/add-new-component`.

### Testing Changes on a Store

To test your changes in a store, you will need to create a pull request (for more guidance, refer to the next section). You can keep your pull request in `draft` while testing.

1. After committing your changes, push them to the remote repo and open a Pull Request.
1. After committing your changes, push them to the remote repository and open a Pull Request.

2. In the checks section, find `ci/codesandbox` and click on `Details`.

<img width="502" alt="checks_details" src="https://vtexhelp.vtexassets.com/assets/docs/src/dropdown-menu-example___338a9acd1892074ba750ada043ab92b4.png"></img>

3. Use the `Local Install Instructions` provided for the PR to **add your version of the packages** as dependencies in the `package.json` file of the [starter](https://github.com/vtex-sites/starter.store) or your store.

<img width="502" alt="image" src="https://vtexhelp.vtexassets.com/assets/docs/src/fs-package-local-install___db14cf215e613a08aca9ba5d779eb37a.png"></img>
<img width="502" alt="image" src="https://vtexhelp.vtexassets.com/assets/docs/src/fs-package-local-install-cli___692a64eba8c0b3745c468176bfc610fb.png
"></img>

4. Run `yarn` to install the updates and test your changes in the store.

4. Run `yarn` to install the updates and test your changes.
**Note**: This link is intended for testing purposes only. Please avoid using it in your store. Once the published version of your package is available, make sure to update the link accordingly.

## Creating Pull Requests
## 4. Creating a Pull Request

We use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification for pull request titles and commit messages.

1. After committing your changes, push them to the remote repo and open a Pull Request.
After committing your changes, push them to the remote repository and open a Pull Request.

### Pull Request Guidelines

1. Please add a clear and concise title PR title with one of the prefixes.

- Available prefixes: `Feat`, `Fix`, `Chore`, `Docs`, `Style`
- Example: `Feat: Add Carousel component`

2. You will be presented with a pull request template. Please describe the motivation behind your changes and provide details about what you have implemented.

3. If applicable, include screenshots and steps for testing. This information will help reviewers understand your contributions better.

4. Add the `contributing` label to identify your PR. And any other [label](https://github.com/vtex/faststore/labels) that is applicable for your PR.

**Note**: If you believe your changes might cause a breaking change, or if you have any concerns about it, please mention this in the pull request description.

## 5. Review Process

Once your PR is submitted, the team will review it.

2. Please add a clear and concise title PR title with one of the prefixes.
Pull requests need only the approval 👍 of two or more maintainers to be merged.

- Available prefixes: `feat`, `fix`, `chore`, `docs`, `style`
- Example: `feat: Add Carousel component`
All contributions will go through a review process. Make sure you keep an eye on the PR, you might need to:

3. You will be presented with a pull request template. Kindly describe the motivation behind and the changes you made. This information will help reviewers in understanding your contributions.
1. Respond to any feedback from reviewers.
2. Make any requested changes by committing to your branch and pushing the updates.

4. Wait for checks to pass and reviews to be approved.
Once your PR is approved, your changes will be merged into the `main` branch and a new release will be initiated, incorporating your updates into the latest version.

5. When your changes are merged, a new release will be initiated, incorporating your updates into the latest version.
Please be patient, as this process can take some time depending on the team’s availability. However, if your changes are critical and you are a client, consider contacting customer support to request priority through a support ticket.

Thanks for contributing 🎉
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</a>
</p>
<h1 align="center">
FastStore v2
FastStore v3
</h1>
<p align="center">
<strong>
Expand Down Expand Up @@ -35,7 +35,7 @@ Check out our [Overview](https://www.faststore.dev/docs/getting-started-overview

## Contributing

This is still a work in progress, however, if you are also an adventurous person, you can read the code and have some fun!
This is a work in progress. If you are an adventurous person, you can read the code and have some fun! Refer to [Contributing guidelines](CONTRIBUTING.MD) for more information.

## Getting help

Expand Down
Loading
Loading