fix: fuzzy and operator usage when handling IS requests #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
hellofanny
changed the title
hellofanny
reviewed
Nov 18, 2024
| @@ -97,4 +111,29 @@ export const useProductGalleryQuery = ({ | |||
| } | |||
| }, | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
The main change that differ from #2204
hellofanny
requested review from
eduardoformiga and
renatomaurovtex
and removed request for
a team
hellofanny
requested review from
lucasfp13 and
lariciamota
and removed request for
renatomaurovtex
eduardoformiga
approved these changes
Nov 19, 2024
## What's the purpose of this pull request? Follow-up of #2568 We are currently sending `search.query` events type instead of `search.autocomplete.query` when typing a term in the search input. This may be affecting some metrics. ## How to test it? Run the project locally or test though this [preview link](https://sfj-029e21e--starter.preview.vtex.app/) 1. Type `apple` in the input search field and press enter (you can slowly type it) 2. Open the `Network Tab` and filter for `event` - You might see some events with `type: "search.autocomplete.query"` <img width="500" alt="image" src="https://github.com/user-attachments/assets/5338b6f0-c6e3-4c21-ac6a-b76b8b452108"> - The last event with the full text should have` type: "search.query"` (and it should be the only event with this type). <img width="921" alt="image" src="https://github.com/user-attachments/assets/37373716-61b6-405b-b51f-52a88a99836a"> ### Starters Deploy Preview vtex-sites/starter.store#618 ## References [Slack thread](https://vtex.slack.com/archives/CP6S9HP46/p1720788576536359?thread_ts=1719365308.548959&cid=CP6S9HP46)
pedromtec
commented
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR aims to correct fuzzy and operator usage when handling Intelligent Search API requests.
Previously, we specified a default value for fuzzy
fuzzy=auto. But we shouldn’t include it on the first request to Search. According to the IS team, the correct behavior should let the search engine decide the best parameters for the search.Re-applies changes made from #2204 without adding the blink effect added previously.
search.queryevent to ISHow it works?
More details on #2204 description.
How to test it?
Run the project locally or test though this preview link
Testing search PLP
appleusing the input search fieldNetwork Taband filter forClientProductGalleryQueryResponsetab: look formetadataobject, thefuzzyandlogicalOperatorvaluesselectedFacetssearch_apple.mov
Testing in Category PLP
TechnologycategoryDuplicate Search event in PLP
appleusing the input search field (at once)Network Taband filter foreventStarters Deploy Preview
vtex-sites/starter.store#617
References
#2204