[POC][SFS-1708] Patch structured logs #2578
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
biancasilvavtex
force-pushed
the
SFS-1708/patch-structured-logs
branch
from
f9e780c to
b6ffc65
Compare
biancasilvavtex
commented
Dec 2, 2024
| @@ -16,7 +16,7 @@ | |||
| "format:generated": "prettier --write \"@generated/**/*.{ts,js,tsx,jsx,json}\" --loglevel error", | |||
| "generate": "na run generate:schema && na run generate:codegen && na run format:generated", | |||
| "prebuild": "na run partytown && na run generate", | |||
| "build": "next build", | |||
| "build": "next build && patch-package", | |||
There was a problem hiding this comment.
Adding the command only here will make us rely on the customer to be able to add such feature.
Ideally, we should add this command to the pipeline to be able to customize the log structure globally.
biancasilvavtex
force-pushed
the
SFS-1708/patch-structured-logs
branch
from
b6ffc65 to
ad92699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a patch:
yarn patch-package next --patch-dir patches/$versionRunning a patch:
patch-package --patch-dir patches/$version... where
$versionis the NextJS version (e.g.13.5.7)