Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add textareafield component #2641

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

artursantiago
Copy link
Collaborator

@artursantiago artursantiago commented Jan 28, 2025

⚠️ THIS PR DEPENDS ON PR#2640 ⚠️

What's the purpose of this pull request?

This pull request adds the TextareaField atom component based on the InputField component. This component will be used in the form of the modal for adding a review to a product in the new Reviews and Ratings section.

How does it work?

This PR introduces the TextareaField molecule component, which extends the functionality of the Textarea component. It accepts additional props such as id, label, error, and disabled, alongside all the standard props of the Textarea component.

The TextareaField uses the Textarea component internally. One thing to pay attention in this implementation is related to the label used in the add new review form. In the Figma design, the label text is very long, which could either exceed the width of the Textarea or break into multiple lines, overlapping the text area.

To solve this, I added a logic using a useEffect hook to dynamically calculate the width of the Textarea and set it as the max-width of the label. Additionally, the text-overflow: ellipsis style is applied to truncate the label text if it exceeds the defined width.

How to test it?

Starters Deploy Preview

Preview

References

JIRA TASK: SFS-2076

Figma

image

@artursantiago artursantiago added enhancement New feature or request depends on Depends on another PR - Please mention the PR labels Jan 28, 2025
@artursantiago artursantiago self-assigned this Jan 28, 2025
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview Jan 28, 2025 5:12pm

Copy link

codesandbox-ci bot commented Jan 28, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@artursantiago artursantiago marked this pull request as ready for review January 30, 2025 17:43
@artursantiago artursantiago requested a review from a team as a code owner January 30, 2025 17:43
@artursantiago artursantiago requested review from renatamottam and renatomaurovtex and removed request for a team January 30, 2025 17:43
@artursantiago artursantiago force-pushed the feat/add-textareafield-component branch from 856cffb to b00cdc0 Compare February 6, 2025 19:59
@artursantiago artursantiago force-pushed the feat/add-textareafield-component branch from b00cdc0 to 21833cd Compare February 6, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on Depends on another PR - Please mention the PR enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant