feat: add review card #2645
Open
feat: add review card #2645
+1,737
−1,542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What's the purpose of this pull request? - Replaces the combination eslint + prettier for [biome](https://biomejs.dev/). - Configure a single lint root for the whole monorepo. It is great for simplicity. Since biome is pretty fast, we can do this without being afraid of the lint command being slow. - It **doest not** fixes the lint issues, this would make this PR big 🦕 (wait for the next one) ## References - https://biomejs.dev/ - https://github.com/vtex/shoreline
## What's the purpose of this pull request? - The fs home is not rendering in Safari. - `requestIdleCallback` is not available in Safari. - This PR creates a polyfill for it
artursantiago
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…es (#2643) ## What's the purpose of this pull request? Use templates for `title` and `description` on PLP for SEO purposes. ## How it works? The store will be able to define their templates through the `discovery.config.js` file just like the example on `discovery.config.default.js` file in this PR. ## How to test it? Check if the metatags for title and description are being built correctly on a Collection page. For example, for the `Just Arrived` collection on the `storeframework` account: | Before | After | | ---- | ---- | | <img width="963" alt="Screenshot 2025-01-28 at 16 33 51" src="https://github.com/user-attachments/assets/4c4146ac-5c46-417b-85f7-59d42a0b645e" /> | <img width="985" alt="Screenshot 2025-01-28 at 16 35 24" src="https://github.com/user-attachments/assets/ed23cb35-9bcf-48f8-8e6f-1bc67b25b6bb" /> | ### Starters Deploy Preview https://storeframework-cm652ufll028lmgv665a6xv0g-omqh42rt5.b.vtex.app/ ([PR](vtex-sites/starter.store#659)) ## References - [Jira task](https://vtex-dev.atlassian.net/jira/software/c/projects/SFS/boards/1051?selectedIssue=SFS-2052) - [Slack thread](https://vtex.slack.com/archives/C089H46Q3B7/p1738074195806699)
# (Don't merge!) ## What's the purpose of this pull request? This POC is an alternative to indexing search pages using [server side rendering](https://nextjs.org/docs/pages/building-your-application/data-fetching/get-server-side-props). As the search page is dynamic and we need to set the title and description based on the search term, we chose to use server side rendering as it is the most suitable for this type of situation. ### Nextjs reference: **Like SSG,[ Server-Side Rendering](https://nextjs.org/docs/basic-features/pages#server-side-rendering) (SSR) is pre-rendered, which also makes it great for SEO. Instead of being generated at build time, as in SSG, SSR's HTML is generated at request time. This is great for when you have pages that are very dynamic.** https://nextjs.org/learn-pages-router/seo/rendering-and-ranking/rendering-strategies ## How it works? We use the getServerSideProps function instead of getStaticProps. We added a cache header to the response so that it is possible to cache the return in a CDN. ## How to test it? Click on: https://storeframework-cm652ufll028lmgv665a6xv0g-polemunmz.b.vtex.app/s?q=headphone
## What's the purpose of this pull request? Since the user is not supposed to change `.faststore`, keeping the githooks and linting on the core package is not useful. - Move lint from core to the root package - Move stylelint to the root package - Move husky and lint-staged to the root package.
…ar (#2639) ## What's the purpose of this pull request? We should not use next/image dependency in our components package. note: We agreed that this component does not fit within our components library, we should move it to core. ## How it works? Adds `ImageComponent` that can use to render the image. Then we can use the next/image in core. ## How to test it? 1. run the application locally or use this [preview](https://starter-371nj2xzn-vtex.vercel.app/headphone-default-99988229/p) 2. go to Headphone Default plp -> check if the SkuMatrixSidebar image is rendered as expected using next/image <img width="500" alt="image" src="https://github.com/user-attachments/assets/af6cc6e2-3879-4d64-bef6-f9ae2556ee15" /> <img width="500" alt="image" src="https://github.com/user-attachments/assets/c84d5d3d-7fff-4b00-954b-5eb5fcc5d28a" /> ### Starters Deploy Preview [WIP] ## References [SFS-2025](https://vtex-dev.atlassian.net/browse/SFS-2025?atlOrigin=eyJpIjoiYmMxNzE0YzAzZDFmNDNkMDg5ZjY1ZmU5MDZjOTE3MzEiLCJwIjoiaiJ9) [SFS-2025]: https://vtex-dev.atlassian.net/browse/SFS-2025?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
## What's the purpose of this pull request? - Unify typescript versions for the monorepo - All packages are in version 5.3.2 - Delete the `/shared` package - Delete the `/eslint-config` package - Remove `//eslint-disable` rules
artursantiago
force-pushed
the
feat/add-review-card
branch
from
e24e403 to
951ff45
Compare
artursantiago
requested review from
emersonlaurentino and
lariciamota
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
How does it work?
The ReviewCard will display the following information:
The card must be responsive and rearrange itself for both desktop and mobile/tablet views.
Compose components were utilized to create the ReviewAuthor and ReviewDate components.
This component will be used in the listing of reviews for a product in the new Reviews and Ratings section.
How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2071
Figma