feat: add h1 in EmptySearch component #2659
Open
+47
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pedromtec
force-pushed
the
SFS-2087-Flagship-blocker-Americanas-Definir-estrat-gia-para-atualiza-o-da-tag-H1-na-p-gina-de-Search
branch
from
4842990 to
0f54346
Compare
pedromtec
requested review from
eduardoformiga and
lucasfp13
and removed request for
a team
eduardoformiga
approved these changes
Jan 31, 2025
| @@ -13,6 +14,25 @@ | |||
| } | |||
| } | |||
|
|
|||
| [data-fs-search-loading] { | |||
|
|
|||
| h1 { | ||
| font-size: var(--fs-text-size-4); | ||
|
|
||
| @include media(">=tablet") { font-size: var(--fs-text-size-5); padding-top: var(--fs-spacing-4); } |
There was a problem hiding this comment.
just trying to keep the pattern
Suggested change
| @include media(">=tablet") { font-size: var(--fs-text-size-5); padding-top: var(--fs-spacing-4); } | |
| @include media(">=tablet") { | |
| font-size: var(--fs-text-size-5); | |
| padding-top: var(--fs-spacing-4); | |
| } |
| @@ -12,6 +12,7 @@ module.exports = { | |||
| titleTemplate: '%s: Search results title', | |||
| descriptionTemplate: '%s: Search results description', | |||
| noIndex: true, | |||
| bodyH1: 'Showing results for:', | |||
There was a problem hiding this comment.
This does the trick so far. For the long term, we should bring this from the hCMS search page settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Render a
<h1 />tag in server side.How it works?
If the flag
enableSearchSSRis enabled, the server side rendering will return a<h1 />tag with the search term.