Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/search by language #18

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Feat/search by language #18

merged 2 commits into from
Feb 9, 2024

Conversation

RobsonOlv
Copy link
Contributor

Description

  • Add facet filter by language
  • Add the possibility to manage the InstantSearch on app side

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@RobsonOlv RobsonOlv requested review from Pvcunha and aliceoq February 5, 2024 21:06
github-actions[bot]
github-actions bot requested changes Feb 5, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']

@RobsonOlv RobsonOlv added the release-no No release bump label Feb 5, 2024
@RobsonOlv RobsonOlv added release-patch Patch version bump and removed release-no No release bump labels Feb 5, 2024
@RobsonOlv RobsonOlv force-pushed the feat/search-by-language branch from 484776d to 3904b53 Compare February 6, 2024 14:43
@RobsonOlv RobsonOlv force-pushed the feat/search-by-language branch from 3904b53 to b3348d1 Compare February 7, 2024 14:00
aliceoq
aliceoq approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@aliceoq aliceoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pvcunha
Pvcunha reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@Pvcunha Pvcunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobsonOlv RobsonOlv merged commit 8392a4b into main Feb 9, 2024
1 check passed
@RobsonOlv RobsonOlv deleted the feat/search-by-language branch February 9, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pvcunha Pvcunha Pvcunha left review comments

@aliceoq aliceoq aliceoq approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
release-patch Patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobsonOlv @Pvcunha @aliceoq