Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning that VTable is deprecated #859

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

julia-rabello
Copy link
Collaborator

@julia-rabello julia-rabello commented Dec 7, 2023

Types of changes

  • New content (guides, endpoints, app documentation)
  • Improvement (make a documentation even better)
  • Fix (fix a documentation error)
  • Spelling and grammar accuracy (self-explanatory)

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Preview Links

Open this URL to set up the portal with this branch changes.

You can now access the edited pages with the following URLs:

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Navigation Preview Link

No changes detected in the navigation.json file

@julia-rabello julia-rabello self-assigned this Dec 7, 2023
@julia-rabello julia-rabello changed the title Update vtable.md VTable deprecation Dec 7, 2023
@julia-rabello julia-rabello changed the title VTable deprecation Add warning that VTable is deprecated Dec 7, 2023
@julia-rabello julia-rabello marked this pull request as ready for review December 7, 2023 21:21
@julia-rabello julia-rabello requested review from a team and karenkrieger and removed request for a team December 7, 2023 21:21
Copy link
Collaborator

@karenkrieger karenkrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julia-rabello julia-rabello merged commit cc20696 into main Dec 8, 2023
4 checks passed
@julia-rabello julia-rabello deleted the vtable-deprecation branch December 8, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants