Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: openapi desired features #474

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Conversation

aliceoq
Copy link
Contributor

@aliceoq aliceoq commented Aug 31, 2023

What is the purpose of this pull request?

To update the rapidoc module to the commit containing the openapi desired features mentioned in this PR

What problem is this solving?

All the problems solved are detailed in this notion page

How should this be manually tested?

Open the preview and check for documentation pages that could be affected by the changes.
It may be necessary to test locally, since the current openapi schemas may not have the necessary changes to test the new features, this fork and branch contains changes to the documentations that make possible to test the new features.

Screenshots or example usage

Screenshots in the notion page.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@aliceoq aliceoq added the release-auto Automatic version bump label Aug 31, 2023
@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for elated-hoover-5c29bf ready!

Name Link
🔨 Latest commit 2a7d22a
🔍 Latest deploy log https://app.netlify.com/sites/elated-hoover-5c29bf/deploys/6536f391fdbfa2000811e291
😎 Deploy Preview https://deploy-preview-474--elated-hoover-5c29bf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

No description provided.

@aliceoq aliceoq requested a review from brunoamui August 31, 2023 18:26
Copy link
Contributor

@julia-rabello julia-rabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @aliceoq! Thank you so much 🚀✨

I've noticed that in the scenario below, where there is anyOf + allOf in the request body, the preview only shows allOf params. Is it possible to fix this?

@carolinamenezes
Copy link
Contributor

LGTM 🚀 ❤️

  • Would it be possible to replace the labels Authentication 1 and Authentication 2 with the type of authentication (e.g., API Key and Bearer Token)?

Screenshot 2023-09-18 at 16 17 50

@brunoamui brunoamui merged commit 7e57ddc into main Oct 23, 2023
5 of 6 checks passed
@brunoamui brunoamui deleted the feat/openapi-desired-features branch October 23, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-auto Automatic version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants