Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slugify function #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: slugify function #131

wants to merge 1 commit into from

Conversation

phvm
Copy link
Contributor

@phvm phvm commented Oct 28, 2024

What is the purpose of this pull request?

Fixing the table of contents slugs

What problem is this solving?

Table of content slugs having missing characters

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@phvm phvm added the release-patch Patch version bump label Oct 28, 2024
@phvm phvm linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 5fa10ef
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/671f8011c820f500087f554d
😎 Deploy Preview https://deploy-preview-131--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! But it just works on the first click.

How I tested:

  1. Synced with your branch
  2. Changed the components dependency declaration to get from the branch fix/slugify
  3. Ran yarn.
  4. Accessed the articles mentioned in the issue.
  5. Clicked any element of the table of contents. If it had a special char, I was able to see that the slug was correct.
  6. If I click any table of contents element with a special char, it would be incorrect. Example:
/pt/docs/tracks/instore-setup-basico#configurar-condies-de-pagamento

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor links da sidebar direita têm erro nas slugs
2 participants