Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: troubleshooting page search #132

Merged
merged 16 commits into from
Dec 17, 2024

Conversation

phvm
Copy link
Contributor

@phvm phvm commented Oct 28, 2024

What is the purpose of this pull request?

Implement a search bar for the troubleshooting page

What problem is this solving?

Other cards list pages have a search bar except the troubleshooting one

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@phvm phvm added the release-minor Minor version bump label Oct 28, 2024
@phvm phvm linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit c22980f
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/6761b57b3d27dc0008145c59
😎 Deploy Preview https://deploy-preview-132--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going too fix the tags in the content repo. Then we'll be able to test this properly.

src/components/troubleshooting-card/index.tsx Outdated Show resolved Hide resolved
src/pages/troubleshooting/index.tsx Outdated Show resolved Hide resolved
src/pages/troubleshooting/index.tsx Outdated Show resolved Hide resolved
src/utils/constants.ts Show resolved Hide resolved
src/utils/typings/types.ts Outdated Show resolved Hide resolved
@julia-rabello
Copy link
Contributor

I reverted the commits that replaced tags with product team and the tags seem to be working properly now.

image

However, the filters are influenced by the values in constants.ts. Since they're not really constants (they depend on the content of markdown files), we need to get these values from help-center-content troubleshooting files. I'm not sure how to generate that list dynamically, and add localization as well (tags are different depending on the language). Do you have any idea how to do that? @PedroAntunesCosta

Should we remove filters while this is not ready? Or just have a static list based on troubleshooting guides so far?

@PedroAntunesCosta
Copy link
Contributor

Should we remove filters while this is not ready? Or just have a static list based on troubleshooting guides so far?

@julia-rabello I think static list is the best. Troubleshooting publication rate is low and the existing articles already cover a wide range of products and features. I think it is unlikely that new tags should be published anytime soon.

But we must address this list in the future, I will create an issue.

Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! But I think we should create a static list for the filters. I have some more considerations on this:

  • Would all tags be too many for the filter picking UI?
  • If so, should we list only products? I feel like this is not the way knowledge should be organized in troubleshooting, but it might help.

@julia-rabello julia-rabello merged commit a437033 into main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Troubleshooting list page search bar
3 participants