-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: troubleshooting page search #132
Conversation
✅ Deploy Preview for leafy-mooncake-7c2e5e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going too fix the tags in the content repo. Then we'll be able to test this properly.
I reverted the commits that replaced tags with product team and the tags seem to be working properly now. However, the filters are influenced by the values in constants.ts. Since they're not really constants (they depend on the content of markdown files), we need to get these values from help-center-content troubleshooting files. I'm not sure how to generate that list dynamically, and add localization as well (tags are different depending on the language). Do you have any idea how to do that? @PedroAntunesCosta Should we remove filters while this is not ready? Or just have a static list based on troubleshooting guides so far? |
@julia-rabello I think static list is the best. Troubleshooting publication rate is low and the existing articles already cover a wide range of products and features. I think it is unlikely that new tags should be published anytime soon. But we must address this list in the future, I will create an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! But I think we should create a static list for the filters. I have some more considerations on this:
- Would all tags be too many for the filter picking UI?
- If so, should we list only products? I feel like this is not the way knowledge should be organized in troubleshooting, but it might help.
What is the purpose of this pull request?
Implement a search bar for the troubleshooting page
What problem is this solving?
Other cards list pages have a search bar except the troubleshooting one
How should this be manually tested?
Screenshots or example usage
Types of changes