-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new tutorial landing page version #134
Conversation
✅ Deploy Preview for leafy-mooncake-7c2e5e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']
@julia-rabello I think many of this weird string changes are due to not updating an old branch from main. Many of these I recognize from the PR I merged with sentence case fixes and feedbacks from localization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardoaerobr in addition to the comments Júlia made above, I would like to point, as we talked earlier in our sync, that the links in the cards don't work. They point to a 404 tutorial. I consider that, given we already know the slugs we want each card to point to, a page with placeholders is not ready for code review.
Please add the slugs to each card, corresponding to the category slug found in public/navigation.json
.
Also, please add a release label. I believe |
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Pedro Antunes <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Card links are still wrong. They should not be
tutorials/{categoryName}
. They should be{docs/tutorial/{categoryName}
- I noticed not all capitalization adjustments were rolled back / synced with main (e.g.
Portal del desarrollador
was changed toPortal del Desarrolador
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The card links are wrong.
https://deploy-preview-134--leafy-mooncake-7c2e5e.netlify.app/pt/docs/docs/tutorial/produtos-beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use category instead of cat (both in navigation.json and messages)? Looking at the result, it would be weird to have slugs like cat-apps, cat-sellers, cat-shipping 🐱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardoaerobr sorry, I think you were correct before not using Tutorials between ' '. Now the deploy fails with this error: |
What is the purpose of this pull request?
What problem is this solving?
How should this be manually tested?
Screenshots or example usage
Types of changes