Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix components' localization and improve navigation file format #146

Merged
merged 14 commits into from
Jan 8, 2025

Conversation

PedroAntunesCosta
Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta commented Dec 13, 2024

What is the purpose of this pull request?

Fix the localization of components' strings.

Related to components PR 32.

How should this be manually tested?

  1. Sync with this branch locally: fix/components-localization-retry.
  2. Change the components import to the correct branch:
    "@vtexdocs/components": "https://github.com/vtexdocs/components.git#fix/localized-strings-retry",
  3. Test different pages and check components' strings, such as the side bar title, the search box place holder and the was this helpful option. They should be localized in PT and ES.

@PedroAntunesCosta PedroAntunesCosta self-assigned this Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 60ceecf
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/677ee20aa8395d0008f848b1
😎 Deploy Preview https://deploy-preview-146--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']

@PedroAntunesCosta PedroAntunesCosta changed the title fix(localization): updating components import branch just for testing Fix components' localization and improve navigation file format Jan 7, 2025
@PedroAntunesCosta PedroAntunesCosta added the release-minor Minor version bump label Jan 8, 2025
@PedroAntunesCosta PedroAntunesCosta merged commit 3b4eafb into main Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants