Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/footer #21

Merged
merged 45 commits into from
Jan 9, 2024
Merged

Feat/footer #21

merged 45 commits into from
Jan 9, 2024

Conversation

Pvcunha
Copy link
Contributor

@Pvcunha Pvcunha commented Dec 21, 2023

What is the purpose of this pull request?

Creates the new footer and its needs.

  1. New social media icons
  2. New site map link
  3. New language switcher for footer

How should this be manually tested?

Run $ yarn run dev and try for the following resolutions: 360, 640, 832, 1280, 1920

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@Pvcunha Pvcunha self-assigned this Dec 21, 2023
Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit a378cfe
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/6595a90668c8430008d86199
😎 Deploy Preview https://deploy-preview-21--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']

@Pvcunha Pvcunha added the release-patch Patch version bump label Dec 21, 2023
Copy link
Contributor

@aliceoq aliceoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Uma coisa que pode mudar depois é pra o dropdown fechar depois de selecionar a linguagem.

@ThayllyR
Copy link
Contributor

ThayllyR commented Jan 2, 2024

LGTM.
Falta somente acrescentar a animação de hoover nas redes sociais. Se possível deixar a opacidade mais clara como no protótipo. Mas está muito bom, parabéns!

Copy link
Contributor

@RobsonOlv RobsonOlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tá ótimo, parabéns! Só esse detalhe em aberto

src/components/footer/styles.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM ✨

@Pvcunha Pvcunha requested a review from RobsonOlv January 3, 2024 14:00
Copy link
Contributor

@RobsonOlv RobsonOlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 👏

@Pvcunha Pvcunha merged commit d1b503c into main Jan 9, 2024
4 checks passed
@Pvcunha Pvcunha deleted the feat/footer branch January 9, 2024 19:56
Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants