Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu e sidebar #22

Merged
merged 96 commits into from
Jan 23, 2024
Merged

Menu e sidebar #22

merged 96 commits into from
Jan 23, 2024

Conversation

Pvcunha
Copy link
Contributor

@Pvcunha Pvcunha commented Jan 8, 2024

What is the purpose of this pull request?

Adiciona os ícones e seções do menu e sidebar, mantém o locale switcher no header quando mobile.

  • Adiciona fallback das secoes do hamburguer menu para a lib
  • Adiciona os icones do menu e sidebar de acordo com o prototipo de alta fidelidade
  • Ajusta header para novo formato de acordo com protótipo de alta fidelidade
  • Adiciona mudança de cor no locale switcher ao clicar para dispositivos mobile
  • Adiciona section de feedback no menu hamburguer.
  • Arruma o bug do icone rosado no menu.

What problem is this solving?

Resolve os icones do menu aparecerem nas resolucoes mobile, em vez de ser os icones da sidebar.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 7a97789
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/65aeb6182c6c740008473258
😎 Deploy Preview https://deploy-preview-22--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pvcunha Pvcunha added the release-minor Minor version bump label Jan 8, 2024
@Pvcunha Pvcunha marked this pull request as ready for review January 19, 2024 16:47
@Pvcunha Pvcunha requested a review from ThayllyR January 19, 2024 16:47
@ThayllyR
Copy link
Contributor

Está ótimo! Faltam as atualizações somente, mas sei que no próximo vão estar! :)

Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Copy link
Contributor

@brunoamui brunoamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Importante adicionar um direcionamento sobre como testar as modificações no PR (Quais rotas acessar e no que prestar atenção)!

Copy link
Contributor

@aliceoq aliceoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pvcunha Pvcunha merged commit 6995119 into main Jan 23, 2024
5 checks passed
@Pvcunha Pvcunha deleted the feat/menu branch January 23, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants