Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tutorials #31

Merged
merged 94 commits into from
Feb 23, 2024
Merged

Feat/tutorials #31

merged 94 commits into from
Feb 23, 2024

Conversation

Pvcunha
Copy link
Contributor

@Pvcunha Pvcunha commented Feb 7, 2024

What is the purpose of this pull request?

Cria páginas de tutoriais & soluções seguindo o protótipo de alta fidelidade.

What problem is this solving?

  • Adiciona páginas de índice como no protótipo de alta fidelidade
  • Botão de paginação "next" não cobre toda a largura do componente quando está sozinho.

How should this be manually tested?

  1. Navegue para a página de Tutorial & solutions
  2. Selecione na sidebar dentre os itens: Beta, Subscription Beta (primeiro filho de beta) ou qualquer documento e compare com o protótipo de alta fidelidade.

Como o navigation ainda precisa ser atualizado, apenas esses dois itens estão configurados para funcionar como índices e o restante ainda se comporta normalmente.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@Pvcunha Pvcunha added the release-minor Minor version bump label Feb 7, 2024
@Pvcunha Pvcunha self-assigned this Feb 7, 2024
Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 4a72eb4
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/65d521828f70720008bd45e3
😎 Deploy Preview https://deploy-preview-31--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ThayllyR
Copy link
Contributor

ThayllyR commented Feb 8, 2024

Está ótimo, Pedro. Só uma questão que seria interessante revisar é o botão de previous e next no mobile. Que tá bem cortado. O restante está exatamento como no protótipo. Muito bom! ✨

@ThayllyR
Copy link
Contributor

ThayllyR commented Feb 8, 2024

Isso está acontecendo em alguns. Mas outros estão ok.

Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨ Ficou ótimo!

@Pvcunha Pvcunha requested a review from ThayllyR February 21, 2024 17:42
@Pvcunha Pvcunha merged commit 2d4adb6 into main Feb 23, 2024
5 checks passed
@Pvcunha Pvcunha deleted the feat/tutorials branch February 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants