Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes links in constants file #34

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix: changes links in constants file #34

merged 1 commit into from
Feb 23, 2024

Conversation

Pvcunha
Copy link
Contributor

@Pvcunha Pvcunha commented Feb 20, 2024

What is the purpose of this pull request?

Update placeholders from menu to right links.

What problem is this solving?

Update placeholders from menu to right links.

Just fix hyperlinks.

How should this be manually tested?

Go to the menu and verify if each item routes to the right page. Specially health check, and status . But feel free to check others as well.

Screenshots or example usage

  1. Go to menu and choose an item.
  2. Check if it rout to the right page.
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@Pvcunha Pvcunha added the release-no No release bump label Feb 20, 2024
Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit a2174ed
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/65d513dddb1b98000876e007
😎 Deploy Preview https://deploy-preview-34--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pvcunha Pvcunha self-assigned this Feb 20, 2024
Copy link
Contributor

@ThayllyR ThayllyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Copy link
Contributor

@aliceoq aliceoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pvcunha Pvcunha merged commit 6a3738a into main Feb 23, 2024
6 checks passed
@Pvcunha Pvcunha deleted the hotfix/menu-links branch February 23, 2024 13:28
@ThayllyR
Copy link
Contributor

Great! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-no No release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants