Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for IntervalArithmetic to 0.22, (keep existing compat) #146

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the IntervalArithmetic package from 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21 to 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2023-12-14-00-07-06-973-02765754720 branch from 66830a9 to 6316769 Compare December 14, 2023 00:07
@vtjeng vtjeng closed this Dec 14, 2023
@vtjeng vtjeng reopened this Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c2a4ca) 91.42% compared to head (687d540) 91.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files          25       25           
  Lines         816      816           
=======================================
  Hits          746      746           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vtjeng
Copy link
Owner

vtjeng commented Dec 14, 2023

CI / Julia 1 - ubuntu-latest - x64 is erroring:

type Interval has no field hi

https://github.com/vtjeng/MIPVerify.jl/actions/runs/7205397880/job/19628338158?pr=146#step:6:2205

The version of Interval installed is v0.22.0:

Source: https://github.com/vtjeng/MIPVerify.jl/actions/runs/7205397880/job/19628338158?pr=146#step:6:46


CI / Julia 1.6 - ubuntu-latest - x64 is not erroring.

The version of Interval installed is v0.20.9:

Source: https://github.com/vtjeng/MIPVerify.jl/actions/runs/7205397880/job/19628337598?pr=146#step:5:48

vtjeng added a commit that referenced this pull request Dec 16, 2023
…inf` and `sup`.

This PR is expected to be a no-op.

## Motivation

This is necessary since the `.hi` field appears to be no longer available in `0.22`: #146 (comment)

## Testing

`inf` and `sup` have been available in the `IntervalArithmetic.jl` package since `0.15`, which is the earliest version of `IntervalArithmetic.jl` our package supports: https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/e19764302e41c1b619b2a50727586be4ff90b6c7/src/IntervalArithmetic.jl#L55.
@vtjeng
Copy link
Owner

vtjeng commented Dec 16, 2023

This needs to be merged on top of #147, which we expect to fix the CI / Julia 1 issue.

vtjeng added a commit that referenced this pull request Dec 16, 2023
…inf` and `sup`.

This PR is expected to be a no-op.

This is necessary since the `.hi` field appears to be no longer available in `0.22`: #146 (comment)

`inf` and `sup` have been available in the `IntervalArithmetic.jl` package since `0.15`, which is the earliest version of `IntervalArithmetic.jl` our package supports: https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/e19764302e41c1b619b2a50727586be4ff90b6c7/src/IntervalArithmetic.jl#L55.
vtjeng added a commit that referenced this pull request Dec 16, 2023
…inf` and `sup`. (#147)

This PR is expected to be a no-op.

This is necessary since the `.hi` field appears to be no longer available in `0.22`: #146 (comment)

`inf` and `sup` have been available in the `IntervalArithmetic.jl` package since `0.15`, which is the earliest version of `IntervalArithmetic.jl` our package supports: https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/e19764302e41c1b619b2a50727586be4ff90b6c7/src/IntervalArithmetic.jl#L55.
@vtjeng vtjeng force-pushed the compathelper/new_version/2023-12-14-00-07-06-973-02765754720 branch from 6316769 to 687d540 Compare December 16, 2023 04:40
@vtjeng vtjeng enabled auto-merge (squash) December 16, 2023 04:41
@vtjeng vtjeng merged commit 29c6063 into master Dec 16, 2023
@vtjeng vtjeng deleted the compathelper/new_version/2023-12-14-00-07-06-973-02765754720 branch December 16, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant