Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

重构助手 #19

Merged
merged 12 commits into from
Sep 10, 2014
Merged

重构助手 #19

merged 12 commits into from
Sep 10, 2014

Conversation

bcho
Copy link
Member

@bcho bcho commented Aug 30, 2014

#18

@vtmer vtmer locked and limited conversation to collaborators Aug 30, 2014
@vtmer vtmer unlocked this conversation Aug 30, 2014
@bcho
Copy link
Member Author

bcho commented Aug 30, 2014

cc @linkkingjay @Yannyezixin

@bcho
Copy link
Member Author

bcho commented Aug 30, 2014

Day 1: http://developer.vtmer.com/2014/08/refactor-gdut-jwgul-helper-p1.html

@bcho
Copy link
Member Author

bcho commented Sep 1, 2014

Day 2: http://developer.vtmer.com/2014/09/refactor-gdut-jwgl-helper-p2.html

@bcho
Copy link
Member Author

bcho commented Sep 3, 2014

Day 3: http://developer.vtmer.com/2014/09/refactor-gdut-jwgl-helper-p3.html

@bcho
Copy link
Member Author

bcho commented Sep 3, 2014

搞定鸟，求 review cc @linkkingjay @Yannyezixin

@bcho bcho changed the title [进行时] 重构助手 ~_~ 重构助手 Sep 3, 2014
@linkkingjay
Copy link
Member

好赞好赞，周末研究下～

@Yannyezixin
Copy link
Member

哇。哟系。研究下。

linkkingjay
linkkingjay reviewed Sep 9, 2014
View reviewed changes
Gruntfile.js
var pem = grunt.template.process(
'<%= dir.manifest %>/gdut-jwgl-helper.pem'
),
cmd = 'chromium --pack-extension=<%= dir.build %>/crx';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcho 我的 chromium 命令是 chromium-browser ，这个可以像 之前的 Makefile 一样做一下兼容吗？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linkkingjay 唔……我想想怎么做判断比较好

@bcho
Copy link
Member Author

bcho commented Sep 9, 2014

@linkkingjay 现在你可以试试用 grunt shell:build_crx --chrome=/usr/bin/chromium-browser 的方法

@linkkingjay
Copy link
Member

@bcho OK 赞～

@bcho
Copy link
Member Author

bcho commented Sep 9, 2014

@linkkingjay 话说我打算定期把一些文章发到飘香那边，你觉得 ok 么？

@linkkingjay
Copy link
Member

@bcho 没问题呀

@bcho
Copy link
Member Author

bcho commented Sep 10, 2014

@Yannyezixin 你 review 得怎样啊！

@bcho
Copy link
Member Author

bcho commented Sep 10, 2014

我先合并啦

bcho added a commit that referenced this pull request Sep 10, 2014
@bcho
Merge pull request #19 from bcho/refactor
5560b2b 
重构助手
@bcho bcho merged commit 5560b2b into vtmer:master Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcho @linkkingjay @Yannyezixin