chore: get input from @actions/core instead of env #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony19
force-pushed
the
feat/inputs-from-actions-core
branch
from
6ef460b
to
8eef1a5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nozomuikuta
suggested changes
Nov 15, 2022
nozomuikuta
reviewed
Nov 15, 2022
| assert(!!process.env.UPSTREAM_REPO, '`upstreamRepo` is required.') | ||
| assert(!!process.env.HEAD_REPO, '`headRepo` is required.') | ||
| assert(!!process.env.TRACK_FROM, '`trackFrom` is required.') | ||
| assert(typeof core !== 'undefined', `core is undefined, which probably means you're not running in a GitHub Action`) |
There was a problem hiding this comment.
Does this assertion mean that we can no longer test the whole logic in our local environments?
If so, how we can test its behavior before release?
There was a problem hiding this comment.
Honestly, I don't recall. This PR is so old, I've completely forgotten the context of this code, but I think this came from example code somewhere. I'll have to dig to find out the reason for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@actions/corepackage instead of from env vars. This reduces config duplication in yaml and avoids manual serialization of inputs.src/index.tsis running in GitHub action