Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): handle KeepAlive children unmount when wrapped in stable v-for #12915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12914

Copy link

github-actions bot commented Feb 19, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+17 B) 38.1 kB (+4 B) 34.4 kB (+62 B)
vue.global.prod.js 158 kB (+17 B) 58 kB (+5 B) 51.6 kB (-4 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB (+17 B) 18.3 kB (+3 B) 16.7 kB (+1 B)
createApp 54.6 kB (+17 B) 21.3 kB (+4 B) 19.4 kB (+5 B)
createSSRApp 58.8 kB (+17 B) 23 kB (+2 B) 21 kB (+5 B)
defineCustomElement 59.4 kB (+17 B) 22.9 kB (+3 B) 20.8 kB (+3 B)
overall 68.6 kB (+17 B) 26.4 kB (+5 B) 24.1 kB (+3 B)

Copy link

pkg-pr-new bot commented Feb 19, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12915

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12915

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12915

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12915

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12915

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12915

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12915

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12915

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12915

vue

npm i https://pkg.pr.new/vue@12915

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12915

commit: 9b6ecde

@edison1105 edison1105 changed the title fix(compiler-core): always track KeepAlive children as block inside v-for fix(runtime-core): handle KeepAlive children unmount when wrapped in stable v-for Feb 20, 2025
@vuejs vuejs deleted a comment from vue-bot Feb 20, 2025
@edison1105
Copy link
Member Author

/ecosystem-ci run

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: keep-alive labels Feb 20, 2025
@vue-bot
Copy link
Contributor

vue-bot commented Feb 20, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: keep-alive
Projects
None yet
2 participants