fix(require-toggle-inside-transition): should respect the attribute "…

…appear"
vuejs · Oct 27, 2023 · e2f1a8d · e2f1a8d
1 parent e6cab77
commit e2f1a8d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/require-toggle-inside-transition.js b/lib/rules/require-toggle-inside-transition.js
@@ -32,6 +32,13 @@ module.exports = {
       if (utils.isCustomComponent(element)) {
         return
       }
+
+      /** @type VElement */ // @ts-expect-error
+      const parent = element.parent
+      if (utils.hasAttribute(parent, 'appear')) {
+        return
+      }
+
       if (
         element.name !== 'slot' &&
         !utils.hasDirective(element, 'if') &&
@@ -50,7 +57,7 @@ module.exports = {
       /** @param {VElement} node */
       "VElement[name='transition'] > VElement"(node) {
         verifyInsideElement(node)
-      },
+      }
     })
   }
 }
diff --git a/tests/lib/rules/require-toggle-inside-transition.js b/tests/lib/rules/require-toggle-inside-transition.js
@@ -66,6 +66,10 @@ tester.run('require-toggle-inside-transition', rule, {
       filename: 'test.vue',
       code: '<template><transition><div :key="k" /></transition></template>'
     },
+    {
+      filename: 'test.vue',
+      code: '<template><transition appear><div /></transition></template>'
+    }
   ],
   invalid: [
     {