Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing suggestions and messages to tests #2402

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Add missing suggestions and messages to tests #2402

merged 1 commit into from
Feb 18, 2024

Conversation

FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann added the meta Code style improvements, build process improvements, refactorings label Feb 13, 2024
@FloEdelmann FloEdelmann mentioned this pull request Feb 13, 2024
Merged
ota-meshi
ota-meshi approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!
Sorry for the late response to everything. Recently, it is difficult for me to participate in OSS because my child was hospitalized.

@ota-meshi ota-meshi merged commit 5227eed into master Feb 18, 2024
17 checks passed
@ota-meshi ota-meshi deleted the fix-tests-v9 branch February 18, 2024 23:40
@FloEdelmann
Copy link
Member Author

Oh, no worries! All the best for you and your child!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
meta Code style improvements, build process improvements, refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @ota-meshi