Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve no-invalid-meta internal rule #2647

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Improve no-invalid-meta internal rule #2647

merged 4 commits into from
Dec 16, 2024

Conversation

FloEdelmann
Copy link
Member

No description provided.

@FloEdelmann FloEdelmann added the meta Code style improvements, build process improvements, refactorings label Dec 13, 2024
waynzh
waynzh approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FloEdelmann FloEdelmann merged commit b5a8260 into master Dec 16, 2024
18 checks passed
@FloEdelmann FloEdelmann deleted the remove-rule-recommended branch December 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynzh waynzh waynzh approved these changes

@ota-meshi ota-meshi Awaiting requested review from ota-meshi

Assignees
No one assigned
Labels
meta Code style improvements, build process improvements, refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @waynzh