test: add tests for #3592 #3595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it's a Vue TS problem, we do a hack for this ( |
|
I've updated this PR! |
johnsoncodehk
force-pushed
the
master
branch
2 times, most recently
from
52d7be2 to
a61bad7
Compare
|
We also need to refactor the current vue-tsc test, otherwise this test will not run. I think the current test directory is a bit confusing, and I want to sort it out first. |
johnsoncodehk
added a commit
that referenced
this pull request
Oct 8, 2023
Co-authored-by: Johnson Chu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3595
I'm not sure if this is the right fix, because I found another issue in vue core: vuejs/core#9296 which might be the root cause of this issue