Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): mapHelpers with getters types (#2571) #2576

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(types): mapHelpers with getters types (#2571) #2576

merged 1 commit into from
Feb 15, 2024

Conversation

gcaaa31928
Copy link
Contributor

@gcaaa31928 gcaaa31928 commented Feb 11, 2024 •
edited
Loading

Close #2571

@netlify Netlify
Copy link

netlify bot commented Feb 11, 2024 •
edited
Loading

✅ Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit e7d605f
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/65ca229ed1144d0008516a27
😎 Deploy Preview https://deploy-preview-2576--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 11, 2024 •
edited
Loading

✅ Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit e7d605f
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/65ca229e4890cd00088e9e59

@gcaaa31928 gcaaa31928 marked this pull request as draft February 12, 2024 14:01
@gcaaa31928 gcaaa31928 marked this pull request as ready for review February 12, 2024 14:10
posva
posva approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! FYI Releasing this will be delayed because of an unrelated type change with declare module

@posva posva merged commit ea5c974 into vuejs:v2 Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gcaaa31928 @posva