Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: indicate compatibility with new v4 major #2694

Merged
merged 2 commits into from
Jun 15, 2024
Merged

chore: indicate compatibility with new v4 major #2694

merged 2 commits into from
Jun 15, 2024

Conversation

danielroe
Copy link
Member

With Nuxt 4 on the horizon, this updates the module compatibility definition to allow it to be installed on Nuxt v4. (Otherwise Nuxt will indicate the module might not be compatible.)

When Nuxt v4 comes out then you might decide or need to make breaking changes in this module and release a new major, but hopefully the migration should be smoother. 🙏

👉 You can follow this and other changes in nuxt/nuxt#27613 - please feel free to provide feedback as well!

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit a89d705
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/666c42c0c9079100086f04a2

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit a89d705
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/666c42c0c84a480008b265ee

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (a665270) to head (a89d705).

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2694      +/-   ##
==========================================
+ Coverage   95.53%   95.98%   +0.44%     
==========================================
  Files          11       11              
  Lines        2912     2912              
  Branches      190      190              
==========================================
+ Hits         2782     2795      +13     
+ Misses        129      115      -14     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva posva merged commit 33bfce1 into v2 Jun 15, 2024
10 checks passed
@posva posva deleted the v4-compatibility branch June 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants