Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contributing guide #2782

Merged
merged 1 commit into from
Sep 30, 2024
Merged

docs: update contributing guide #2782

merged 1 commit into from
Sep 30, 2024

Conversation

jh-leong
Copy link
Member

Update the repository link and recommend using the official Pinia playground for bug reports instead of jsfiddle.net :)

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 1eb7c33
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/66fa6a15885a760008a440c3
😎 Deploy Preview https://deploy-preview-2782--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit 1eb7c33
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/66fa6a15badf02000869b745

Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@pinia/nuxt@2782
pnpm add https://pkg.pr.new/pinia@2782
pnpm add https://pkg.pr.new/@pinia/testing@2782

commit: 1eb7c33

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (0d8bce8) to head (1eb7c33).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2782      +/-   ##
==========================================
- Coverage   92.43%   90.41%   -2.03%     
==========================================
  Files          14       14              
  Lines        1335     1335              
  Branches      220      220              
==========================================
- Hits         1234     1207      -27     
- Misses        101      127      +26     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit cbc79df into vuejs:v2 Sep 30, 2024
8 of 9 checks passed
@jh-leong jh-leong deleted the fix/docs branch September 30, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants