Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): do not serialize skipHydrate properties #2798

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

kabalage
Copy link
Contributor

@kabalage kabalage commented Oct 13, 2024

Fixes #2773
Let me know if anything else is needed.

@kabalage kabalage force-pushed the feat/nuxt-skip-hydrate-in-payload branch from 08257f9 to b90150f Compare October 13, 2024 10:45
@kabalage kabalage force-pushed the feat/nuxt-skip-hydrate-in-payload branch from b90150f to 4746ff2 Compare October 13, 2024 10:46
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the base branch from feat/nuxt-skip-hydrate-in-payload to v2 October 17, 2024 03:00
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 85223ea
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/67107e0fa056730008541e6d
😎 Deploy Preview https://deploy-preview-2798--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 85223ea
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/67107e0fb7e2c80008a03a27
😎 Deploy Preview https://deploy-preview-2798--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 17, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/pinia@2798
pnpm add https://pkg.pr.new/@pinia/testing@2798
pnpm add https://pkg.pr.new/@pinia/nuxt@2798

commit: 85223ea

@posva posva changed the title fix(nuxt): fix skipHydrate payload plugin and add test feat(nuxt): do not serialize skipHydrate properties Oct 17, 2024
@posva posva merged commit e645fc1 into vuejs:v2 Oct 17, 2024
7 checks passed
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (432544e) to head (85223ea).
Report is 3 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2798      +/-   ##
==========================================
- Coverage   90.11%   89.06%   -1.05%     
==========================================
  Files          14       14              
  Lines        1335     1335              
  Branches      220      217       -3     
==========================================
- Hits         1203     1189      -14     
- Misses        131      145      +14     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shuuji3 added a commit to elk-zone/elk that referenced this pull request Nov 27, 2024
v2.2.6 fixed bug where `shouldHydrate()` is not exported that breaks `pnpm build`
(ref. vuejs/pinia#2798)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State marked with skipHydrate should not be included in the Nuxt payload
2 participants