feat(nuxt): supports automatic import of stores from extend layers #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-playground canceled.
|
✅ Deploy Preview for pinia-official canceled.
|
wzc520pyfm
changed the title
posva
requested changes
Nov 28, 2024
| @@ -101,6 +101,10 @@ const module: NuxtModule<ModuleOptions> = defineNuxtModule<ModuleOptions>({ | |||
| if (options.storesDirs) { | |||
| for (const storeDir of options.storesDirs) { | |||
| addImportsDir(resolve(nuxt.options.rootDir, storeDir)) | |||
|
|
|||
| for (const layer of nuxt.options._layers) { | |||
There was a problem hiding this comment.
Isn't this an internal property? 😓 Let's use a public API
commit: |
|
I noticed there is also #2757, so let's use that one instead. Thanks for the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #2828 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 14 14
Lines 1323 1323
Branches 218 219 +1
=======================================
Hits 1182 1182
Misses 140 140
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I install pinia in a nuxt layer and create
storesfolder, and then I extend this layer in another nuxt application, I find that thestoresare not automatically imported.What this PR does:
When addImportsDir, consider the nuxt layers also.
Refer:
Pinia autoImports for nuxt
Nuxt layers