Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check with document for browser instead of window #2042

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: check with document for browser instead of window #2042

merged 1 commit into from
Dec 1, 2023

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 16, 2023 •
edited
Loading

Deno has global window object. Thus, when trying to deploy a typical Vue SSR project, the server output fails to run.

So, replaced the browser check with document instead.
VitePress is also doing the same.

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 9accc4e
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/65561b5cedecfc0008947674

@ydcjeff ydcjeff changed the title fix: check document for browser instead of window fix: check with document for browser instead of window Nov 16, 2023
@posva posva merged commit 5631732 into vuejs:main Dec 1, 2023
4 checks passed
@ydcjeff ydcjeff deleted the patch-1 branch December 2, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydcjeff @posva