Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to webpack 4 (latest) #378

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

upgrade to webpack 4 (latest) #378

wants to merge 3 commits into from

Conversation

jensb1
Copy link

@jensb1 jensb1 commented Jan 12, 2020

Upgraded to latest packages incl. webpack 4.

@jensb1

This comment has been minimized.

@fipp
Copy link

fipp commented Sep 17, 2020

Hi @jensb1. This is maybe not on the top of your mind anymore, but I tried to rebase the project on top of yours to get webpack 4. Having some issues with grpc. The server starts OK but on the first request I get this error:

Error: Failed to load /Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/src/node/extension_binary/node-v83-darwin-x64-unknown/grpc_node.node. Cannot find module '/Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/src/node/extension_binary/node-v83-darwin-x64-unknown/grpc_node.node'
Require stack:
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/src/grpc_extension.js
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/src/client_interceptors.js
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/src/client.js
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/index.js
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/@firebase/firestore/dist/index.node.cjs.js
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/firebase/dist/index.node.cjs.js
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/vue-server-renderer/build.dev.js
- /Users/terje/tmp/vue-hackernews-2.0/node_modules/vue-server-renderer/index.js
- /Users/terje/tmp/vue-hackernews-2.0/server.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1080:15)
    at Function.Module._load (internal/modules/cjs/loader.js:923:27)
    at Module.require (internal/modules/cjs/loader.js:1140:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at Object.<anonymous> (/Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/src/grpc_extension.js:32:13)
    at Module._compile (internal/modules/cjs/loader.js:1251:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1272:10)
    at Module.load (internal/modules/cjs/loader.js:1100:32)
    at Function.Module._load (internal/modules/cjs/loader.js:962:14)
    at Module.require (internal/modules/cjs/loader.js:1140:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at Object.<anonymous> (/Users/terje/tmp/vue-hackernews-2.0/node_modules/grpc/src/client_interceptors.js:144:12)
    at Module._compile (internal/modules/cjs/loader.js:1251:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1272:10)
    at Module.load (internal/modules/cjs/loader.js:1100:32)
    at Function.Module._load (internal/modules/cjs/loader.js:962:14)

Running on OSX. Have any idea on how to resolve the issue?

@fipp
Copy link

fipp commented Sep 17, 2020

Bumping firebase to 7.20.0 seem to have solved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants