Adding babel config inside "using-with-jest.md" #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2020 16:36
Adding more detailed "using with babel" paragraph since it was not fully complete and required additional steps that were not present in documentation. #1666
lmiller1990
approved these changes
Aug 29, 2020
docs/installation/using-with-jest.md
Outdated
| > **Note:** If you are using Babel 7 or higher, you will need to add [babel-bridge](https://github.com/babel/babel-bridge) to your devDependencies (`$ npm install --save-dev babel-core@^7.0.0-bridge.0`). | ||
| ### Using with Babel | ||
|
|
||
| If you are goind to use `babel` and import vue single file components with `.vue` extension inside your tests, you will need to install babel and transform `.js` files with `babel-jest` . |
There was a problem hiding this comment.
If you are going (going typo)
There was a problem hiding this comment.
Yes, excuse me, missed it, i should auto check for typos next time around.
docs/installation/using-with-jest.md
Outdated
| ```json | ||
| { | ||
| "jest": { | ||
| ... |
There was a problem hiding this comment.
Can we remove the ... and comment so people can easily copy paste this?
Marked WIP because i knew there were some other small final changes to be made (and there were few). Its ready for review now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more detailed "using with babel" paragraph since it was not fully complete and required
additional steps that were not present in using-with-jest documentation section.
#1666
What kind of change does this PR introduce? (check at least one)
Adding more description to docs
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)There is no need for new tests, as all
.mdformatting tests pass.If adding a new feature, the PR's description includes:
Other information: