-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(runtime-vapor): optimize setDOMProp
on static tag + key
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
setDOMProp
on static tag + keysetDOMProp
on static tag + key
Size ReportBundles
Usages
|
setDOMProp
on static tag + keysetDOMProp
on static tag + key
Open in Stackblitz • playground @vue/compiler-core
@vue/compiler-ssr
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-shared
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
@vue/vapor
commit: |
edison1105
commented
Nov 29, 2024
if (value === oldVal) return | ||
|
||
if (key === 'innerHTML' || key === 'textContent') { | ||
// TODO special checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this special check is no longer necessary
yyx990803
requested changes
Dec 1, 2024
packages/compiler-vapor/__tests__/transforms/__snapshots__/vBind.spec.ts.snap
Outdated
Show resolved
Hide resolved
yyx990803
approved these changes
Dec 1, 2024
LittleSound
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compile changes:
innerHTML
, usesetHtml
directly.textContent
, usesetText
directly.value
and the element is notprogress
orcustom-element
, usesetValue
directly.runtime changes:
setDOMProp
.setValue
method.