Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom query and mutation arguments passing #1509

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Apr 3, 2024

closing: https://alokai.atlassian.net/browse/ES-373

[FIXED] Correctly passing properties and options to customQuery and customMutation SDK methods. Previously, the customHeaders option was not being passed properly. Now, all options will be properly passed to the customQuery and customMutation methods.

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bartoszherba bartoszherba requested a review from a team as a code owner April 3, 2024 07:46
Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 50a78be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/magento-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bartoszherba bartoszherba force-pushed the fix/custom-query-mutation-params-pass branch 2 times, most recently from 5c5998a to dfaa661 Compare April 3, 2024 10:06
@bartoszherba bartoszherba force-pushed the fix/custom-query-mutation-params-pass branch from dfaa661 to 50a78be Compare April 3, 2024 10:40
@bartoszherba bartoszherba merged commit c5d6306 into main Apr 3, 2024
8 checks passed
@bartoszherba bartoszherba deleted the fix/custom-query-mutation-params-pass branch April 3, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants