docs(VDatePicker): remove display-value from props list #20879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Sek
changed the title
displayValue from props listdisplay-value from props list
|
v2 had the ability to display a different date as "today" that seems to be missing in v3: https://v2.vuetifyjs.com/en/components/date-pickers/#show-current |
|
Not sure if |
johnleider
reviewed
Feb 6, 2025
Comment on lines
61
to
64
| const { daysInMonth, model, weekNumbers } = useCalendar({ | ||
| ...props, | ||
| displayValue: null, | ||
| }) |
There was a problem hiding this comment.
Thoughts on reverting this and instead making displayValue optional in the CalendarProps interface?
There was a problem hiding this comment.
I agree, it should not be required in CalendarProps.
J-Sek
force-pushed
the
fix/20863-datepicker-displayValue
branch
from
8775ade to
50a4aed
Compare
johnleider
approved these changes
Feb 10, 2025
johnleider
changed the title
display-value from props list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
display-valuedoes not affect VDatePicker and should not appear in API docs to avoid confusionresolves #20863