feat(component): wrap leave
variant internally
#239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Linked issue
โ Type of change
๐ Description
This conditionally wraps the motion component in a transition if a leave variant is provided, this should remove the need for users the do this manually. I'm not entirely sure what implications this has on passed attributes or other nested component/element behaviors, we could consider putting this behind a config flag if it causes issues.
In the current implementation it adds a
present
prop that serves the same purpose asv-if
, it would be ideal if we could make thev-if
directive apply on the wrapped/nested element instead.๐ Checklist