Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): wrap leave variant internally #239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Oct 19, 2024

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

This conditionally wraps the motion component in a transition if a leave variant is provided, this should remove the need for users the do this manually. I'm not entirely sure what implications this has on passed attributes or other nested component/element behaviors, we could consider putting this behind a config flag if it causes issues.

In the current implementation it adds a present prop that serves the same purpose as v-if, it would be ideal if we could make the v-if directive apply on the wrapped/nested element instead.

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant