Fix range facets and add tests. #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Nov 20, 2024
There was a problem hiding this comment.
@EreMaijala, I'm still seeing the problem that Ursula reported on the mailing list. Steps to reproduce:
1.) Do a blank search with multi-select facets turned on
2.) Apply multiple filters: Institution:MyInstitution and Date: 1800-2050
3.) Apply multiple filters: Library:weird_ids.mrc and Date: 1830-2030
At this point, the date facet does not update, and you end up with conflicting values in the URL.
Fixes applying of multiple changes at once.
|
@demiankatz Thanks for testing and reporting. Should be fixed now. And tests improved too to cover this case. |
demiankatz
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.