Multi facet selection - Record last user state #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Nov 28, 2024
| @@ -140,6 +140,7 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() { | |||
| const activation_event = 'facet-selection-begin'; | |||
| const deactivation_event = 'facet-selection-cancel'; | |||
| const apply_event = 'facet-selection-done'; | |||
| const localStorageVariableName = 'multiFacetsSelection'; | |||
There was a problem hiding this comment.
Other consts are in snake_case
| @@ -313,6 +318,7 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() { | |||
| toggleSelectedFacetStyle(elem); | |||
| } | |||
| } | |||
| saveUserSelectionLastState(isMultiFacetsSelectionActivated); | |||
There was a problem hiding this comment.
While it doesn't hurt here, I think the proper place for this is inside the if (typeof enable !== 'undefined') { block above.
| @@ -338,6 +344,7 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() { | |||
| const activationElem = context.querySelector('.js-user-selection-multi-filters'); | |||
| if (activationElem) { | |||
| activationElem.addEventListener('change', function multiFacetSelectionChange() { toggleMultiFacetsSelection(this.checked); } ); | |||
| toggleMultiFacetsSelection(localStorage.getItem(localStorageVariableName) === 'true'); | |||
There was a problem hiding this comment.
Since there's saveUserSelectionLastState, there should also be getUserSelectionLastState or such to retrieve the selected state (as a boolean).
| function saveUserSelectionLastState(state) { | ||
| localStorage.setItem(localStorageVariableName, state); | ||
| } | ||
|
|
||
| function toggleMultiFacetsSelection(enable) { | ||
| if (typeof enable !== 'undefined') { | ||
| isMultiFacetsSelectionActivated = enable; |
There was a problem hiding this comment.
I think we need to return early here if enable === isMultiFacetsSelectionActivated. Otherwise on initialization this function can run with enable === false without any previous activation and do useless work and emit an event that doesn't reflect reality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the multi facets js selection, record user choice in local storage