Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility of record checkboxes and cursors for checkboxes and select elements #4124

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
+102 −24
Open

Improve accessibility of record checkboxes and cursors for checkboxes and select elements #4124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96d1166
adjust record checkboxes height to fit content
ThoWagen Nov 28, 2024
8ea306f
Merge branch 'dev' into pull-request/record-checkbox-fit-content
ThoWagen Nov 28, 2024
68453ba
Merge branch 'dev' into pull-request/record-checkbox-fit-content
ThoWagen Nov 28, 2024
61007f4
improved mouseovers
ThoWagen Dec 2, 2024
ad9c8ae
increased checkbox label size
ThoWagen Dec 2, 2024
794b12d
Merge branch 'dev' into pull-request/record-checkbox-fit-content
ThoWagen Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion themes/bootprint3/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion themes/bootstrap3/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion themes/bootstrap3/less/bootstrap.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ $fa-font-path: "../../bootstrap3/css/fonts";

html { font-size: 14px; } // Root font size from Bootstrap, allows consistent use of rem units
a,
label { cursor: pointer; }
label,
select,
input[type="checkbox"] { cursor: pointer; }
.alert.alert-info a { text-decoration: underline; }
.alert-default {
border-color: @well-border;
Expand Down
22 changes: 21 additions & 1 deletion themes/bootstrap3/less/components/search.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ header .container.navbar { margin-bottom: 0; }
.selection-controls-bar {
gap: 0.25rem;
align-items: center;
cursor: default;
}
.bulkActionButtons {
margin-block: 1rem;
Expand Down Expand Up @@ -187,7 +188,22 @@ header .container.navbar { margin-bottom: 0; }
padding-top: 1rem;

.record-checkbox,
.record-number { display: none; }
.record-number {
display: none;
}

.record-checkbox {
padding: .4rem;
height: fit-content;

input[type="checkbox"] {
margin: 0;
}
}

.record-number {
padding-top: .2rem;
}

.title,
.result-author,
Expand Down Expand Up @@ -687,6 +703,10 @@ body.rtl {
.clear-selection, label {
padding: .25rem .4rem .15rem .4rem;
}

input[type="checkbox"] {
margin-right: .4rem;
}
}

.active-filters .filters a.filter-value:hover,
Expand Down
4 changes: 3 additions & 1 deletion themes/bootstrap3/scss/bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ $fa-font-path: "../../bootstrap3/css/fonts";

html { font-size: 14px; } // Root font size from Bootstrap, allows consistent use of rem units
a,
label { cursor: pointer; }
label,
select,
input[type="checkbox"] { cursor: pointer; }
.alert.alert-info a { text-decoration: underline; }
.alert-default {
border-color: $well-border;
Expand Down
22 changes: 21 additions & 1 deletion themes/bootstrap3/scss/components/search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ header .container.navbar { margin-bottom: 0; }
.selection-controls-bar {
gap: 0.25rem;
align-items: center;
cursor: default;
}
.bulkActionButtons {
margin-block: 1rem;
Expand Down Expand Up @@ -187,7 +188,22 @@ header .container.navbar { margin-bottom: 0; }
padding-top: 1rem;

.record-checkbox,
.record-number { display: none; }
.record-number {
display: none;
}

.record-checkbox {
padding: .4rem;
height: fit-content;

input[type="checkbox"] {
margin: 0;
}
}

.record-number {
padding-top: .2rem;
}

.title,
.result-author,
Expand Down Expand Up @@ -687,6 +703,10 @@ body.rtl {
.clear-selection, label {
padding: .25rem .4rem .15rem .4rem;
}

input[type="checkbox"] {
margin-right: .4rem;
}
}

.active-filters .filters a.filter-value:hover,
Expand Down
12 changes: 8 additions & 4 deletions themes/bootstrap3/templates/myresearch/bulk-action-buttons.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,19 @@
<ul class="selection-controls-bar">
<?php if(in_array($checkboxSelectAllType, ['on_page', 'both'])): ?>
<li class="bulk-checkbox">
<input type="checkbox" name="selectAll" class="checkbox-select-all" id="myresearchCheckAll">
<label for="myresearchCheckAll"><?=$this->transEsc('select_all_on_page')?></label>
<label for="myresearchCheckAll">
<input type="checkbox" name="selectAll" class="checkbox-select-all" id="myresearchCheckAll">
<?=$this->transEsc('select_all_on_page')?>
</label>
</li>
<?php endif; ?>
<?php if($multiPageSelection && in_array($checkboxSelectAllType, ['global', 'both'])): ?>
<li class="bulk-checkbox">
<div class="select-all-global hidden">
<input type="checkbox" name="selectAllGlobal" class="checkbox-select-all-global" id="myresearchCheckAllGlobal">
<label for="myresearchCheckAllGlobal"><?=$this->transEsc('select_all')?></label>
<label for="myresearchCheckAllGlobal">
<input type="checkbox" name="selectAllGlobal" class="checkbox-select-all-global" id="myresearchCheckAllGlobal">
<?=$this->transEsc('select_all')?>
</label>
</div>
</li>
<?php endif; ?>
Expand Down
6 changes: 4 additions & 2 deletions themes/bootstrap3/templates/search/bulk-action-buttons.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@
</ul>
<ul class="selection-controls-bar">
<li class="bulk-checkbox">
<input type="checkbox" class="checkbox-select-all" name="selectAll" id="<?=$this->idPrefix?>addFormCheckboxSelectAll"<?php if ($this->formAttr): ?> form="<?=$this->escapeHtmlAttr($this->formAttr) ?>"<?php endif; ?>>
<label for="<?=$this->idPrefix?>addFormCheckboxSelectAll"><?=$this->transEsc('select_all_on_page')?></label>
<label for="<?=$this->idPrefix?>addFormCheckboxSelectAll">
<input type="checkbox" class="checkbox-select-all" name="selectAll" id="<?=$this->idPrefix?>addFormCheckboxSelectAll"<?php if ($this->formAttr): ?> form="<?=$this->escapeHtmlAttr($this->formAttr) ?>"<?php endif; ?>>
<?=$this->transEsc('select_all_on_page')?>
</label>
</li>
</ul>
</nav>
Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap5/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion themes/bootstrap5/scss/bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ $fa-font-path: "../../bootstrap5/css/vendor/font-awesome/webfonts";

html { font-size: 14px; } // Root font size from Bootstrap, allows consistent use of rem units
a,
label { cursor: pointer; }
label,
select,
input[type="checkbox"] { cursor: pointer; }
.alert.alert-info a { text-decoration: underline; }
.alert-default {
border-color: $well-border;
Expand Down
22 changes: 21 additions & 1 deletion themes/bootstrap5/scss/components/search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ header .container.navbar { margin-bottom: 0; }
.selection-controls-bar {
gap: 0.25rem;
align-items: center;
cursor: default;
}
.bulkActionButtons {
margin-block: 1rem;
Expand Down Expand Up @@ -187,7 +188,22 @@ header .container.navbar { margin-bottom: 0; }
padding-top: 1rem;

.record-checkbox,
.record-number { display: none; }
.record-number {
display: none;
}

.record-checkbox {
padding: .4rem;
height: fit-content;

input[type="checkbox"] {
margin: 0;
}
}

.record-number {
padding-top: .2rem;
}

.title,
.result-author,
Expand Down Expand Up @@ -687,6 +703,10 @@ body.rtl {
.clear-selection, label {
padding: .25rem .4rem .15rem .4rem;
}

input[type="checkbox"] {
margin-right: .4rem;
}
}

.active-filters .filters a.filter-value:hover,
Expand Down
12 changes: 8 additions & 4 deletions themes/bootstrap5/templates/myresearch/bulk-action-buttons.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,19 @@
<ul class="selection-controls-bar">
<?php if(in_array($checkboxSelectAllType, ['on_page', 'both'])): ?>
<li class="bulk-checkbox">
<input type="checkbox" name="selectAll" class="checkbox-select-all" id="myresearchCheckAll">
<label for="myresearchCheckAll"><?=$this->transEsc('select_all_on_page')?></label>
<label for="myresearchCheckAll">
<input type="checkbox" name="selectAll" class="checkbox-select-all" id="myresearchCheckAll">
<?=$this->transEsc('select_all_on_page')?>
</label>
</li>
<?php endif; ?>
<?php if($multiPageSelection && in_array($checkboxSelectAllType, ['global', 'both'])): ?>
<li class="bulk-checkbox">
<div class="select-all-global hidden">
<input type="checkbox" name="selectAllGlobal" class="checkbox-select-all-global" id="myresearchCheckAllGlobal">
<label for="myresearchCheckAllGlobal"><?=$this->transEsc('select_all')?></label>
<label for="myresearchCheckAllGlobal">
<input type="checkbox" name="selectAllGlobal" class="checkbox-select-all-global" id="myresearchCheckAllGlobal">
<?=$this->transEsc('select_all')?>
</label>
</div>
</li>
<?php endif; ?>
Expand Down
6 changes: 4 additions & 2 deletions themes/bootstrap5/templates/search/bulk-action-buttons.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@
</ul>
<ul class="selection-controls-bar">
<li class="bulk-checkbox">
<input type="checkbox" class="checkbox-select-all" name="selectAll" id="<?=$this->idPrefix?>addFormCheckboxSelectAll"<?php if ($this->formAttr): ?> form="<?=$this->escapeHtmlAttr($this->formAttr) ?>"<?php endif; ?>>
<label for="<?=$this->idPrefix?>addFormCheckboxSelectAll"><?=$this->transEsc('select_all_on_page')?></label>
<label for="<?=$this->idPrefix?>addFormCheckboxSelectAll">
<input type="checkbox" class="checkbox-select-all" name="selectAll" id="<?=$this->idPrefix?>addFormCheckboxSelectAll"<?php if ($this->formAttr): ?> form="<?=$this->escapeHtmlAttr($this->formAttr) ?>"<?php endif; ?>>
<?=$this->transEsc('select_all_on_page')?>
</label>
</li>
</ul>
</nav>
Expand Down
2 changes: 1 addition & 1 deletion themes/local_theme_example/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion themes/sandal/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion themes/sandal5/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.