Primo REST: Add record attribute and CDI full text search support. #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EreMaijala
commented
Nov 29, 2024
EreMaijala
commented
- Adds a new checkbox facet for toggling full text search with CDI.
- Adds a setting for displaying CDI record attributes as record labels.
- Adds displaying of labels to record screen.
- Updates links to documentation in Primo.ini.
|
Screenshots: Retracted record: Primo result: Blended search result: |
demiankatz
requested changes
Nov 29, 2024
module/VuFindSearch/src/VuFindSearch/Backend/Primo/Response/RecordCollectionFactory.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Demian Katz <[email protected]>
Co-authored-by: Demian Katz <[email protected]>
…cordCollectionFactory.php Co-authored-by: Demian Katz <[email protected]>
|
@demiankatz I changed all the other record factory calls as well for consistency. |
|
@demiankatz And the language files should be sorted now. |
demiankatz
pushed a commit
that referenced
this pull request
Nov 29, 2024
|
(I split off the existing factory revisions to a separate commit for clarity, and pushed that up ahead of merging this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.