[VUFIND-1745] Drop remaining support for compiling scss files in PHP. #4219
+19
−643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
added
the
architecture
demiankatz
requested changes
Jan 29, 2025
| * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License | ||
| * @link https://vufind.org Main Site | ||
| */ | ||
| class ScssCompiler extends AbstractCssPreCompiler |
There was a problem hiding this comment.
Should we also remove AbstractCssPreCompiler? I don't envision us reviving this logic in the future....
|
Note that this PR is currently on hold until @RLangeUni has an opportunity to review whether it is worth devoting resources to modernizing the PHP compiler, or to locally switch to using the Node compiler instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be discussed in the next Community Call.
The PHP-based style compilation has been undocumented since removal of active LESS compilation from the PHP code and does not work properly. It might be possible to make it work, but I don't believe we should try to maintain two separate compilation paths.
TODO: