Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update first/second/non-creative roles #4255

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

dltj
Copy link
Contributor

@dltj dltj commented Feb 17, 2025

  1. Sorted secondAuthorRoles codes and nonCreativeRoles codes
  2. Diff'd a combined list of first-, second-, and noncreative-roles with the RelatorSynonyms list (which were updated as part of #4214)
  3. Added the missing relator codes into the secondAuthorRoles and nonCreativeRoles

There were many arbitrary decisions make in the third step. For instance, is a medium ("A person held to be a channel of communication between the earthly world and a world of spirits.") a secondAuthorRole or a nonCreativeRole? I picked non-creative. You might make different decisions.

1. Sorted `secondAuthorRoles` and `nonCreativeRoles`
2. Diff'd a combined list of first-, second-, and noncreative-roles with the `RelatorSynonyms` list (which were updated as part of #[4214](vufind-org#4214)
3. Added the missing relator codes into the `secondAuthorRoles` and `nonCreativeRoles`

There were many arbitrary decisions make in the third step. For instance, is a _medium_ ("A person held to be a channel of communication between the earthly world and a world of spirits.") a `secondAuthorRole` or a `nonCreativeRole`? I picked non-creative. You might make different decisions.
@demiankatz demiankatz added this to the 11.0 milestone Feb 18, 2025
@demiankatz demiankatz requested a review from lahmann February 18, 2025 13:25
@demiankatz
Copy link
Member

Thanks, @dltj! Since @lahmann created the initial defaults here, I'd be interested in his opinion on these changes... but as you say, we can expect opinions to vary in some cases, and fortunately, it's easy enough to reconfigure as needed. I'll leave this open for a while to collect feedback.

If it's not too much trouble, I wonder if it would make sense to open a separate PR to simply alphabetize the lists, so it's easier to look at the diffs and see what's added where in this PR. I don't want to put you to a lot of trouble, though, if you'd have to do all the work over again to accomplish that!

@dltj
Copy link
Contributor Author

dltj commented Feb 18, 2025

Oh, good! A second opinion would be helpful.

Unfortunately, only kept the last artifact of the process — the diff between the combined list of codes. These codes were missing from three lists plus where I ended up putting them:

Code Label Position
abr Abridger Second
adi Art director Second
ape Appellee Second
apl Applicant Second
ato Autographer Second
brd Broadcaster Non-creative
brl Braille embosser Non-creative
cas Caster Non-creative
cor Collection registrar Non-creative
cou Court governed Non-creative
crt Court reporter Non-creative
dgs Degree supervisor Non-creative
dir Conductor Second
edc Editor of compilation Second
enj Enacting jurisdiction Non-creative
fds Film distributor Non-creative*
fmk Filmmaker Non-creative
grt Graphic technician Second
his Host institution Non-creative
isb Issuing body Non-creative
jud Judge Non-creative
jug Juristiction goverened Non-creative
kad Cadential author Second
med Medium Non-creative
mtk Minute taker Non-creative
osp Onscreen preseter Second
pan Panelist Second
pra Praeses Second
prv Provider Non-creative
rcd Recordist Second
rdd Radio director Second
rpc Radio producer Second
rsr Restorationalist Second
sdg Stage director Second
sll Seller Non-creative
stg Setting Non-creative
tld Television director Second
tlp Television producer Second
wac Writer of added commentary Second
wal Writer of added lyrics Second
wat Writer of added text Second
win Writer of introduction Second
wpr Writer of preface Second
wst Writer of supplementary textual content Second
  • Good thing I went back and checked my work — I missed Film Distributor

@demiankatz
Copy link
Member

@dltj, most of these make sense to me. Just a couple that might be worth reconsidering:

  • Filmmaker is defined in the term list as "A person, family or organization responsible for creating an independent or personal film. A filmmaker is individually responsible for the conception and execution of all aspects of the film." -- this sounds like a creative role to me.
  • I'm not sure I'd consider "autographer" a creative role, though I can see arguments either way. (Not asking you to change this one, but curious if anyone has strong feelings about it one way or the other).
  • I'm not really sure how these legal relators are used in practice, but it seems inconsistent that we'd call an appellee a creative role and a judge a non-creative role. Shouldn't the legal roles be treated consistently?

@dltj
Copy link
Contributor Author

dltj commented Feb 20, 2025

Ah, yes, Filmmaker does sound like a creative role — I'll make that change in the final update on the pull request. Autographer, like Medium and others, seemed very much a judgment call — happy to be convinced either way if other commenters have thoughts.

The grouping of legal roles is an interesting question. I guess I was thinking of the platonic ideal of the legal system where the judge is not creative and is just an officer of the court. But making them all the same might make sense.

@demiankatz
Copy link
Member

Ah, yes, Filmmaker does sound like a creative role — I'll make that change in the final update on the pull request. Autographer, like Medium and others, seemed very much a judgment call — happy to be convinced either way if other commenters have thoughts.

Thanks!

The grouping of legal roles is an interesting question. I guess I was thinking of the platonic ideal of the legal system where the judge is not creative and is just an officer of the court. But making them all the same might make sense.

I've never seen a record using these relators, so I'm really not sure how they are applied. But if, for example, this is used on a record for a written court ruling that the judge wrote, I would think treating that as a creative role definitely makes sense. If it's used on a transcript of a trial, I would think that would not be significantly different from recording a participant in a documentary (which I believe is handled equivalently to an actor in a fictional film). But maybe there's some other application I'm not thinking of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants