-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update first/second/non-creative roles #4255
base: dev
Are you sure you want to change the base?
Conversation
1. Sorted `secondAuthorRoles` and `nonCreativeRoles` 2. Diff'd a combined list of first-, second-, and noncreative-roles with the `RelatorSynonyms` list (which were updated as part of #[4214](vufind-org#4214) 3. Added the missing relator codes into the `secondAuthorRoles` and `nonCreativeRoles` There were many arbitrary decisions make in the third step. For instance, is a _medium_ ("A person held to be a channel of communication between the earthly world and a world of spirits.") a `secondAuthorRole` or a `nonCreativeRole`? I picked non-creative. You might make different decisions.
Thanks, @dltj! Since @lahmann created the initial defaults here, I'd be interested in his opinion on these changes... but as you say, we can expect opinions to vary in some cases, and fortunately, it's easy enough to reconfigure as needed. I'll leave this open for a while to collect feedback. If it's not too much trouble, I wonder if it would make sense to open a separate PR to simply alphabetize the lists, so it's easier to look at the diffs and see what's added where in this PR. I don't want to put you to a lot of trouble, though, if you'd have to do all the work over again to accomplish that! |
Oh, good! A second opinion would be helpful. Unfortunately, only kept the last artifact of the process — the diff between the combined list of codes. These codes were missing from three lists plus where I ended up putting them:
|
@dltj, most of these make sense to me. Just a couple that might be worth reconsidering:
|
Ah, yes, Filmmaker does sound like a creative role — I'll make that change in the final update on the pull request. Autographer, like Medium and others, seemed very much a judgment call — happy to be convinced either way if other commenters have thoughts. The grouping of legal roles is an interesting question. I guess I was thinking of the platonic ideal of the legal system where the judge is not creative and is just an officer of the court. But making them all the same might make sense. |
Thanks!
I've never seen a record using these relators, so I'm really not sure how they are applied. But if, for example, this is used on a record for a written court ruling that the judge wrote, I would think treating that as a creative role definitely makes sense. If it's used on a transcript of a trial, I would think that would not be significantly different from recording a participant in a documentary (which I believe is handled equivalently to an actor in a fictional film). But maybe there's some other application I'm not thinking of. |
secondAuthorRoles
codes andnonCreativeRoles
codesRelatorSynonyms
list (which were updated as part of #4214)secondAuthorRoles
andnonCreativeRoles
There were many arbitrary decisions make in the third step. For instance, is a medium ("A person held to be a channel of communication between the earthly world and a world of spirits.") a
secondAuthorRole
or anonCreativeRole
? I picked non-creative. You might make different decisions.