Clean up legacy styles and remove bs3-compat.scss

module/VuFind/tests/integration-tests/src/VuFindTest/Mink/AccountMenuTest.php

@@ -384,7 +384,7 @@ public function testStatusBadges(): void
         );
         $this->assertEquals(
             'Items due later: 1 ,',
-            $this->findCssAndGetText($checkoutsStatus, '.visually-hidden, .sr-only')
+            $this->findCssAndGetText($checkoutsStatus, '.visually-hidden')
         );
 
         $this->assertEquals(
@@ -393,7 +393,7 @@ public function testStatusBadges(): void
         );
         $this->assertEquals(
             'Items due soon: 2 ,',
-            $this->findCssAndGetText($checkoutsStatus, '.visually-hidden, .sr-only', null, 1)
+            $this->findCssAndGetText($checkoutsStatus, '.visually-hidden', null, 1)
         );
 
         $this->assertEquals(
@@ -402,7 +402,7 @@ public function testStatusBadges(): void
         );
         $this->assertEquals(
             'Items overdue: 3 ,',
-            $this->findCssAndGetText($checkoutsStatus, '.visually-hidden, .sr-only', null, 2)
+            $this->findCssAndGetText($checkoutsStatus, '.visually-hidden', null, 2)
         );
 
         // Holds
@@ -413,7 +413,7 @@ public function testStatusBadges(): void
         );
         $this->assertEquals(
             'Available for Pickup: 1 ,',
-            $this->findCssAndGetText($holdsStatus, '.visually-hidden, .sr-only')
+            $this->findCssAndGetText($holdsStatus, '.visually-hidden')
         );
 
         $this->assertEquals(
@@ -422,7 +422,7 @@ public function testStatusBadges(): void
         );
         $this->assertEquals(
             'In Transit: 2 ,',
-            $this->findCssAndGetText($holdsStatus, '.visually-hidden, .sr-only', null, 1)
+            $this->findCssAndGetText($holdsStatus, '.visually-hidden', null, 1)
         );
 
         $this->assertEquals(
@@ -431,7 +431,7 @@ public function testStatusBadges(): void
         );
         $this->assertEquals(
             'Other Status: 3 ,',
-            $this->findCssAndGetText($holdsStatus, '.visually-hidden, .sr-only', null, 2)
+            $this->findCssAndGetText($holdsStatus, '.visually-hidden', null, 2)
         );
 
         // Fines

module/VuFind/tests/integration-tests/src/VuFindTest/Mink/FeedbackTest.php

@@ -229,7 +229,7 @@ public function testFeedbackAdmin(): void
         $this->assertEquals("All {$this->getVuFindUrl()}/", $this->findCss($page, '#site_url')->getText());
 
         // Set the first message to "in progress" status:
-        $this->findCss($page, '.form-control.status_update')->setValue('in progress');
+        $this->findCss($page, '.form-feedback-list .status_update')->setValue('in progress');
         $this->waitForPageLoad($page);
         $this->assertEquals(
             'Feedback status updated successfully',

themes/bootstrap5/js/advanced_search.js

@@ -120,7 +120,7 @@ function addGroup(_firstTerm, _firstField, _join, isUser = false) {
     .on("click", function deleteGroupHandler() {
       return deleteGroup($(this).data('nextGroup'));
     });
-  $newGroup.find('select.form-control')
+  $newGroup.find('.adv-group-match select')
     .attr('id', 'search_bool' + nextGroup)
     .attr('name', 'bool' + nextGroup + '[]');
   $newGroup.find('.search_bool')

themes/bootstrap5/js/channels.js

@@ -119,13 +119,15 @@ VuFind.register('channels', function Channels() {
           data: {tab: 'description'}
         })
           .done(function channelPopoverDone(data) {
-            var newContent = '<div class="btn-group btn-group-justified">'
+            var newContent = '<div class="d-flex">'
+              + '<div class="btn-group flex-fill">'
               + '<a href="' + VuFind.path + '/Channels/Record?'
               + 'id=' + encodeURIComponent(record.attr('data-record-id'))
               + '&source=' + encodeURIComponent(record.attr('data-record-source'))
               + '" class="btn btn-default">' + VuFind.translate('channel_expand') + '</a>'
               + ' <a href="' + record.attr('href') + '" class="btn btn-default">' + VuFind.translate('View Record') + '</a>'
               + '</div>'
+              + '</div>'
               + data;
             loadingPopover.dispose();
             new bootstrap.Popover(

themes/bootstrap5/js/visual_facets.js

@@ -34,7 +34,7 @@ function settext() {
 }
 
 function setscreenreader() {
-  this.attr("class", "sr-only")
+  this.attr("class", "visually-hidden")
     .text(function createTextForScreenReader(d) {
       if (typeof d.parentfield !== "undefined") {
         return VuFind.translate('visual_facet_parent') + " " + d.parentlevel;

themes/bootstrap5/scss/bootstrap-variable-overrides.scss

@@ -1,4 +1,4 @@
-// From a11y:
+// These colors ensure proper contrast:
 $primary:         #265680 !default;
 $success:         #028302 !default;
 $info:            #1C5F74 !default;
@@ -18,6 +18,9 @@ $warning-border-subtle:     darken(adjust-hue($warning-bg-subtle, -10), 5%) !def
 $danger-bg-subtle:          #f2dede !default;
 $danger-border-subtle:      darken(adjust-hue($danger-bg-subtle, -10), 5%) !default;
 
+$input-border-color:        #888 !default;
+$form-select-border-color:  #888 !default;
+
 $breadcrumb-bg:                     #f5f5f5 !default;
 $breadcrumb-padding-y:              8px !default;
 $breadcrumb-padding-x:              15px !default;
@@ -47,6 +50,8 @@ $form-switch-bg-image-dark:         none !default;
 $navbar-dark-toggler-icon-bg:       none !default;
 $navbar-light-toggler-icon-bg:      none !default;
 
+$enable-caret:                      false !default;
+
 $link-hover-decoration:             underline !default;
 $icon-link-underline-offset:        inherit !default;
 
@@ -60,5 +65,4 @@ $enable-smooth-scroll:              false !default;
 $enable-validation-icons:           false !default;
 $form-select-indicator-padding:     .75rem !default;
 
-$table-bg-accent:                   #f9f9f9 !default;
 $table-striped-bg:                  #f9f9f9 !default;