Reduce use of substr for readability/performance. (#14)

CHANGELOG.md

@@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file, in reverse
 ### Changed
 
 - The minimum PHP version requirement has been raised to 8.0.
+- The str_starts_with and str_ends_with functions have been used instead of substr where possible.
 
 ### Deprecated
 

src/VuFindCode/EAN.php

@@ -92,10 +92,8 @@ public static function getEAN13CheckDigit($ean)
     public static function isValidEAN13($ean)
     {
         $ean = static::normalizeEAN($ean);
-        if (strlen($ean) != 13) {
-            return false;
-        }
-        return
-            substr($ean, 12) == self::getEAN13CheckDigit(substr($ean, 0, 12));
+        return (strlen($ean) != 13)
+            ? false
+            : str_ends_with($ean, self::getEAN13CheckDigit(substr($ean, 0, 12)));
     }
 }

src/VuFindCode/ISBN.php

@@ -84,7 +84,7 @@ public function get10()
                 return $this->raw;
             } elseif (
                 strlen($this->raw) == 13
-                && substr($this->raw, 0, 3) == '978'
+                && str_starts_with($this->raw, '978')
             ) {
                 // Is it a Bookland EAN?  If so, we can convert to ISBN-10.
                 $start = substr($this->raw, 3, 9);
@@ -176,10 +176,9 @@ public static function getISBN10CheckDigit($isbn)
     public static function isValidISBN10($isbn)
     {
         $isbn = self::normalizeISBN($isbn);
-        if (strlen($isbn) != 10) {
-            return false;
-        }
-        return substr($isbn, 9) == self::getISBN10CheckDigit(substr($isbn, 0, 9));
+        return (strlen($isbn) != 10)
+            ? false
+            : str_ends_with($isbn, self::getISBN10CheckDigit(substr($isbn, 0, 9)));
     }
 
     /**

src/VuFindCode/ISMN.php

@@ -83,7 +83,7 @@ public function get10()
                 return $this->raw;
             } elseif (
                 strlen($this->raw) == 13
-                && substr($this->raw, 0, 3) == '979'
+                && str_starts_with($this->raw, '979')
             ) {
                 // Is it a music EAN?  If so, we can convert to ISMN-10.
                 $start = 'M' . substr($this->raw, 4, 8);