Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust plans printer for new supported engines #505

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

christhemorse
Copy link
Contributor

@christhemorse christhemorse commented Jan 22, 2025

Description

This PR cleans up a few Managed Database Redis references and adjusts the plans printer to include Valkey/Kafka as supported engines and some engine-specific field adjustments: disk is hidden for Valkey plans just like in the API and VCPUs and RAM are hidden for Kafka.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse self-assigned this Jan 22, 2025
Copy link

Unit Tests and Coverage

Show Output
	github.com/vultr/vultr-cli/v3		coverage: 0.0% of statements

Pusher: @christhemorse, Action: pull_request_target

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@optik-aper optik-aper merged commit a74b3cd into vultr:master Jan 22, 2025
4 checks passed
@christhemorse christhemorse deleted the dbaas-supported-engines-fix branch January 22, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants